Skip to content

Conversation

@leslie-wang
Copy link
Contributor

Signed-off-by: Leslie Qi Wang leslie.qiwa@gmail.com

  • [Y] I've read Contribution guide
  • [T] I've tested everything that doesn't relate to tcell.Screen API

Screen Shot 2020-01-20 at 11 39 23 PM

Close #76

Close viktomas#76

Signed-off-by: Leslie Qi Wang <leslie.qiwa@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.78%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage     100%   99.21%   -0.79%     
==========================================
  Files           7        7              
  Lines         248      255       +7     
==========================================
+ Hits          248      253       +5     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
interactive/reporter.go 96.87% <75%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af23dd1...5e545a7. Read the comment docs.

@viktomas
Copy link
Owner

@leslie-wang thanks for another contribution! It's great to see the handling of edge case like this. Please make sure you add tests for all code that you add.

Could you please check whether it would be possible to use the native range loop or the native utf8 library to avoid adding unnecessary dependencies?

@kanlac kanlac mentioned this pull request May 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unicode support

3 participants