Current time display shows 0:00 while seeking

[fansubscat]

Description

When using the currentTimeDisplay control, when the users seeks the video to a different time, the current time is initially displayed as the new seeked time, but when the real seek begins, the time is set to "0:00", and does not return to the real time until the seek has finished. This was introduced in #8988. The issue is reproducible in 8.23.4, but it is not present in the previous stable release (8.21.1).

This bug was already mentioned in a comment in that PR, see #8988 (comment)

Reduced test case

https://codepen.io/fansubscat/pen/zxqJaXP

Steps to reproduce

1. Use currentTimeDisplay in your controls.
2. Start playing the video.
3. Seek to a different time.
4. The control displays "0:00" until the seek has been completed.

Errors

No response

What version of Video.js are you using?

v8.23.4

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chrome 142

What OS(es) and version(s) does this occur with?

Debian Linux 12

[mister-ben]

This condition is wrong:

video.js/src/js/control-bar/time-controls/current-time-display.js

Lines 38 to 40 in d203eab

	} else if (event && event.target && typeof event.target.pendingSeekTime === 'function') {
	time = event.target.pendingSeekTime();
	} else {

A click on the seek bar will always generate an event where event.target.pendingSeekTime is a function, but that function is only useful when one of the disableSeekWhileScrubbing modes is active.

There should be a check for event.target.pendingSeekTime() !== null in that condition, allowing fall through to the next else block.

[phloxic]

@mister-ben, makes sense, thanks. I tried (possibly the typeof check can be omitted):

diff --git a/src/js/control-bar/time-controls/current-time-display.js b/src/js/control-bar/time-controls/current-time-display.js
index f252b631..8c0d8245 100644
--- a/src/js/control-bar/time-controls/current-time-display.js
+++ b/src/js/control-bar/time-controls/current-time-display.js
@@ -35,7 +35,7 @@ class CurrentTimeDisplay extends TimeDisplay {

     if (this.player_.ended()) {
       time = this.player_.duration();
-    } else if (event && event.target && typeof event.target.pendingSeekTime === 'function') {
+    } else if (event && event.target && typeof event.target.pendingSeekTime === 'function' && event.target.pendingSeekTime() !== null) {
       time = event.target.pendingSeekTime();
     } else {
       time = (this.player_.scrubbing()) ? this.player_.getCache().currentTime : this.player_.currentTime();j

However during seek (regardless of seeking by scrubbing or click on target position) the current time display still jumps to 0:00, and only afterwards to the target time. Diff above fixed thanks to correction by @mister-ben.

[mister-ben]

The typeof check is needed as that method can be called from other sources. The condition should check for null rather than 0, as that is what is returned by pendingSeekTime() when its internal property is unset.

[phloxic]

@mister-ben, duh, I should learn to read first. Thank you. That fixes it for me.