Skip to content

Conversation

@mister-ben
Copy link
Contributor

Fixes #9133. #8988 causes the current time display to show 0:00 while seeking as it's getting the current time from a method on seek bar that won't always return a useful value.

Adds a null check to allow fall through to getting currentTime.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.31%. Comparing base (d203eab) to head (ecf2567).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9135   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         120      120           
  Lines        8154     8154           
  Branches     1964     1964           
=======================================
  Hits         6875     6875           
  Misses       1279     1279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current time display shows 0:00 while seeking

2 participants