Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghetto fix for search page offset #25

Closed
wants to merge 2 commits into from
Closed

ghetto fix for search page offset #25

wants to merge 2 commits into from

Conversation

zyhp
Copy link

@zyhp zyhp commented Nov 27, 2019

¯_(ツ)_/¯ i'm not a js dev, don't quote me in what i did cuz i know isn't a proper fix, i just debugged based on what i know about.


This change is Reviewable

@cswl
Copy link

cswl commented Nov 28, 2019

                if ( (offset * 25)  > grandTotal) {
                    log.warn('Ended because API returned an empty page.');
                    return end();

                }
                
               
                log.debug(`Cur offset ${offset} : total  : ${total}  ${grandTotal}`)
                // Forcefully increase offset owo
                offset = offset + 25;
     			return await recurse();
                 
            }

Can you test with this one?

@victornpb
Copy link
Owner

possibly fixed in the last release, LMK it it fixed for you @zyhp @cswl

@victornpb victornpb added the is-bug Something isn't working label Jan 7, 2020
@victornpb victornpb closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants