Detected 770 messages but deleted 0 message

[TetraTheta]

I am trying to delete messages about 20 months ago(2018.02). When I press 'Start' button, result says there are 770 messages but deletes 0 message. I scrolled to that message and tried again. Same thing happened.

In this case, I didn't set 'Range' option. But When I set 'Range' option starting from very first message I've sent to last message I've sent, It stops to delete message at 26th deletion, so #23 might be related to.

Started at 2019. 11. 22. 오전 12:44:29
authorId="REDACTED" channelId="REDACTED" afterMessageId="REDACTED" beforeMessageId="REDACTED" hasLink=false hasFile=false
Total messages found: 704	(Messages in current page: 25, Author: 25, System: 0)	offset: 0
Delete delay: 100ms, Search delay: 100ms	Last Ping: 681ms, Average Ping: 681ms
Estimated time remaining: 0h 9m 12s
Waiting for your confirmation...
OK
0.14% (1/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.28% (2/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.43% (3/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.57% (4/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.71% (5/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.85% (6/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
0.99% (7/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.14% (8/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.28% (9/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.42% (10/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.56% (11/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.70% (12/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.85% (13/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
1.99% (14/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.13% (15/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.27% (16/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.41% (17/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.56% (18/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.70% (19/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.84% (20/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
2.98% (21/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
3.13% (22/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
3.27% (23/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
3.41% (24/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
3.55% (25/704)	Deleting ID:REDACTED REDACTED (REDACTED): REDACTED	
Searching next messages in 100ms...	
Total messages found: 704	(Messages in current page: 0, Author: 0, System: 0)	offset: 0
Delete delay: 100ms, Search delay: 100ms	Last Ping: 301ms, Average Ping: 277ms
Estimated time remaining: 0h 4m 28s
Ended because API returned an empty page.
Ended at 2019. 11. 22. 오전 12:44:40! Total time: 0h 0m 10s
Delete delay: 100ms, Search delay: 100ms	Last Ping: 301ms, Average Ping: 277ms
Rate Limited: 0 times. Total time throttled: 0h 0m 0s.
Deleted 25 messages, 0 failed.

I get this exact issue as well. It finds all my messages but it just stops

Ended because API returned an empty page.

same as the above user

[LandyLane]

Having this issue as well.

[an0nan0nan0n]

I also starting hitting this issue. Maybe the API was updated so we need a fix?

[ncorv]

it seems as though they are rate limiting by changing the search results, notably making the first page blank.

has anyone been able to figure out the endpoint called when scrolling through pages in the search history on the official client? i believe that there just needs to be another conditional inside of recurse() to handle the situation of no results but total > 0

[victornpb]

They announced in their changelog, that now you can search by oldest. They could also have changed something else in there.

maybe this new sorting option could be also used to delete messages more efficiently.

[victornpb]

Someone opened a pull request #25, but it doesn't look right, because it seems that there's no end condition now, and it will run forever, until you tell it to stop.

it seems that this line for some reason is triggering too soon.
https://github.com/victornpb/deleteDiscordMessages/blob/3835fe7864070c118e37a8fd7fcd1a5dc4b32e9c/deleteDiscordMessages.js#L273

[zyhp]

your 'offset' isn't increasing, so the 'page' is always the first one.

open fiddler and check the request when you change the search page, the 'offset' increases by 25 everytime.

all i did, cuz i needed a fast fix and didn't care about it being perfect or permanent, was to check if the page was empty like u do, and sum 25 to the offset, so it goes to the next page.

[zyhp]

to permanent fix it, just figure out what is the 'max offset' you can go, and if the 'offset' goes higher than it 'return', else, keep adding to the offset.

[redring600]

@zyhp I'm sorry, but I'm not as experienced as you. Would you please explain what you did in simpler terms so I can get a temporary fix? I'm running into this same error on a particular DM I need to deal with.

[ncorv]

look at the changes he made to the code. he only changed two lines

in the exit condition (api gives empty page) he changed it so it will not end(), but will instead add 25 to the offset and call recurse() again.

[redring600]

I feel like a complete idiot, and I'm sure I'm seen as that way, but I don't understand what lines were changed. I am so sorry, I just have zero programming experience. Would someone please be so kind as to give me something to paste and tell me where to paste it?

[ncorv]

https://github.com/victornpb/deleteDiscordMessages/blob/e2ee9c30867554d70bf3562370ea3ce4f571ffe8/deleteDiscordMessages.js
this is a link to zyhp's pull request.

paste his pull request instead of the current version.

it is IMPORTANT that you watch this thing work. when you get lots of empty results you MUST refresh the discord page to stop the script. hammering the api like that is very noticeable and very bad for your account

[zyhp]

i will see if i can push a solid fix later, as soon as i have time again i will take a look.

[redring600]

Ah, this is working @nacorv . Thank you so much! So very, very much!

[ncorv]

do not leave it unattended. stop it the moment you get a couple empty results in a row.

it is important to realize the script can lead to account termination even when it is working correctly.