Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct/go record out of range #2202

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Correct/go record out of range #2202

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f6f4a8
Fix the invalid go record range from 0 start.
Shylock-Hg Jul 2, 2020
3eba773
Not return error when zero record from, change it to 1 instead of.
Shylock-Hg Jul 2, 2020
80c372c
Add check for record range iteration.
Shylock-Hg Jul 2, 2020
8894e8b
Print current step when record check fatal.
Shylock-Hg Jul 2, 2020
c2c9381
Add case cover zero to zero steps.
Shylock-Hg Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add case cover zero to zero steps.
  • Loading branch information
@Shylock-Hg
Shylock-Hg committed Jul 2, 2020
commit c2c93816b8685107a5100f16478e50273db34316
14 changes: 14 additions & 0 deletions src/graph/test/GoTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,6 +2371,20 @@ TEST_P(GoTest, Contains) {
}

TEST_P(GoTest, WithIntermediateData) {
// zero to zero
{
cpp2::ExecutionResponse resp;
auto &player = players_["Tony Parker"];
auto *fmt = "GO 0 TO 0 STEPS FROM %ld OVER like YIELD DISTINCT like._dst";
auto query = folly::stringPrintf(fmt, player.vid());
auto code = client_->execute(query, resp);
ASSERT_EQ(cpp2::ErrorCode::SUCCEEDED, code);

std::vector<std::tuple<VertexID>> expected = {
};
ASSERT_TRUE(verifyResult(resp, expected));
}
// simple
{
cpp2::ExecutionResponse resp;
auto &player = players_["Tony Parker"];
Expand Down