Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct/go record out of range #2202

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Correct/go record out of range #2202

merged 5 commits into from
Jul 2, 2020

Conversation

Shylock-Hg
Copy link
Contributor

What changes were proposed in this pull request?

Fix the zero record crash.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above
  • I've informed the technical writer about the documentation change if necessary

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Jul 2, 2020
dutor
dutor previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dutor
dutor previously approved these changes Jul 2, 2020
View reviewed changes
@Shylock-Hg Shylock-Hg requested a review from dutor July 2, 2020 02:55
@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Jul 2, 2020
@dutor dutor merged commit 9443588 into vesoft-inc:master Jul 2, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Aug 5, 2020
@Shylock-Hg @xuguruogu
Correct/go record out of range (vesoft-inc#2202)
3b910bc 
* Fix the invalid go record range from 0 start.
Reduce the extra response copy when record.

* Not return error when zero record from, change it to 1 instead of.

* Add check for record range iteration.

* Print current step when record check fatal.

* Add case cover zero to zero steps.
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@Shylock-Hg
Correct/go record out of range (vesoft-inc#2202)
0ac80c4 
* Fix the invalid go record range from 0 start.
Reduce the extra response copy when record.

* Not return error when zero record from, change it to 1 instead of.

* Add check for record range iteration.

* Print current step when record check fatal.

* Add case cover zero to zero steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@laura-ding laura-ding laura-ding approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shylock-Hg @dutor @laura-ding