Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick (#1700) #1711

Merged
merged 1 commit into from
Feb 3, 2020
Merged

cherry pick (#1700) #1711

merged 1 commit into from
Feb 3, 2020

Conversation

jude-zhu
Copy link
Contributor

@jude-zhu jude-zhu commented Feb 3, 2020

cherry pick #1700

@CPWstatic @jude-zhu
Report error if schema null. (vesoft-inc#1700)
da8da2c 
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8a9daec)
(cherry picked from commit 65364c2)
monadbobo
monadbobo approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jude-zhu jude-zhu added the ready-for-testing PR: ready for the CI test label Feb 3, 2020
@dutor dutor merged commit 48569fa into vesoft-inc:v1.0.0-rc3 Feb 3, 2020
@jude-zhu jude-zhu deleted the cherry-pick-1700 branch June 10, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monadbobo monadbobo monadbobo approved these changes

@yixinglu yixinglu yixinglu approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@knightXun knightXun Awaiting requested review from knightXun

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jude-zhu @monadbobo @yixinglu @dutor @CPWstatic