Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error if schema null, hot fix for issue 1699. #1700

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

CPWstatic
Copy link
Contributor

No description provided.

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Jan 22, 2020
@knightXun
Copy link
Contributor

related to issue: #1699

@jude-zhu
Copy link
Contributor

@knightXun we need more test cases 😁😁

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor merged commit 8a9daec into vesoft-inc:master Feb 2, 2020
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Feb 3, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8a9daec)
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Feb 3, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8a9daec)
(cherry picked from commit 65364c2)
@jude-zhu jude-zhu mentioned this pull request Feb 3, 2020
dutor pushed a commit that referenced this pull request Feb 3, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8a9daec)
(cherry picked from commit 65364c2)

Co-authored-by: CPWstatic <13495049+CPWstatic@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
…er push-down rules. (vesoft-inc#1700)

- Added some tck tests.

Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
…esoft-inc#1709)

* - Fix the setting of colNames and exchanging of PlanNodes in two filter push-down rules. (vesoft-inc#1700)

- Added some tck tests.

Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>

* Fix the setting of colNames in 3 optimizers' rules.

Co-authored-by: nebula-bots <88429921+nebula-bots@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants