-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report error if schema null, hot fix for issue 1699. #1700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to issue: #1699 |
@knightXun we need more test cases 😁😁 |
monadbobo
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bright-starry-sky
approved these changes
Jan 22, 2020
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
Feb 3, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 8a9daec)
Merged
dutor
pushed a commit
that referenced
this pull request
Feb 3, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…er push-down rules. (vesoft-inc#1700) - Added some tck tests. Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…two filter push-down rules. (vesoft-inc#1700)" (vesoft-inc#1704) This reverts commit b1f7f6f.
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…esoft-inc#1709) * - Fix the setting of colNames and exchanging of PlanNodes in two filter push-down rules. (vesoft-inc#1700) - Added some tck tests. Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com> * Fix the setting of colNames in 3 optimizers' rules. Co-authored-by: nebula-bots <88429921+nebula-bots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.