Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sequence-point-related undefined behaviour #1062

Merged
merged 2 commits into from
Oct 15, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/meta/processors/admin/AdminClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void AdminClient::getResponse(
LOG(INFO) << "Rpc failure to " << hosts[index]
<< ", retry " << retry
<< ", limit " << retryLimit;
index = ++index % hosts.size();
index = (index + 1) % hosts.size();
getResponse(std::move(hosts),
index,
std::move(req),
Expand Down Expand Up @@ -337,7 +337,7 @@ void AdminClient::getResponse(
LOG(INFO) << "The leader is in election"
<< ", retry " << retry
<< ", limit " << retryLimit;
index = ++index % hosts.size();
index = (index + 1) % hosts.size();
getResponse(std::move(hosts),
index,
std::move(req),
Expand Down Expand Up @@ -385,7 +385,7 @@ void AdminClient::getResponse(
<< " from " << hosts[index]
<< ", retry " << retry
<< ", limit " << retryLimit;
index = ++index % hosts.size();
index = (index + 1) % hosts.size();
getResponse(std::move(hosts),
index,
std::move(req),
Expand Down