Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sequence-point-related undefined behaviour #1062

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Fixed sequence-point-related undefined behaviour #1062

merged 2 commits into from
Oct 15, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Oct 14, 2019

As title.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Oct 14, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

monadbobo
monadbobo approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yixinglu
yixinglu approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 43094c3 into vesoft-inc:master Oct 15, 2019
@dutor dutor deleted the fix-ub branch October 15, 2019 07:29
whitewum pushed a commit to whitewum/nebula that referenced this pull request Oct 16, 2019
@dutor @whitewum
Fixed sequence-point-related undefined behaviour (vesoft-inc#1062)
d720862
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
Fixed sequence-point-related undefined behaviour (vesoft-inc#1062)
aae5e00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monadbobo monadbobo monadbobo approved these changes

@yixinglu yixinglu yixinglu approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@critical27 critical27 Awaiting requested review from critical27

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dutor @nebula-community-bot @monadbobo @yixinglu