Skip to content

Add option to show release URL instead of opening it in the browser #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leo merged 4 commits into from
Dec 31, 2018
Merged

Add option to show release URL instead of opening it in the browser #126

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8656e92
add option to show release URL instead of opening it in the browser
mcansh Apr 23, 2018
3db3ab7
rename url arg to show-url
mcansh Dec 11, 2018
1e40dd8
rename url arg to show-url
mcansh Dec 11, 2018
9b23905
Fixed URL
leo Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions bin/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ args
.option('pre', 'Mark the release as prerelease')
.option('overwrite', 'If the release already exists, replace it')
.option('publish', 'Instead of creating a draft, publish the release')
.option(['H', 'hook'], 'Specify a custom file to pipe releases through');
.option(['H', 'hook'], 'Specify a custom file to pipe releases through')
.option('show-url', 'Show the release URL instead of opening it in the browser');

const flags = args.parse(process.argv);

Expand Down Expand Up @@ -83,7 +84,8 @@ const createRelease = async (tag, changelog, exists) => {

const methodPrefix = exists ? 'edit' : 'create';
const method = `${methodPrefix}Release`;
const {pre, publish} = flags;
const {pre, publish, showUrl} = flags;


const body = {
owner: repoDetails.user,
Expand Down Expand Up @@ -120,11 +122,12 @@ const createRelease = async (tag, changelog, exists) => {
// Wait for the GitHub UI to render the release
await sleep(500);

if (releaseURL) {
if (showUrl && releaseURL) {
console.log(`\n${chalk.bold('Done!')} ${releaseURL}`);
} else if (releaseURL) {
open(releaseURL);
console.log(`\n${chalk.bold('Done!')} Opening release in browser...`);
}

console.log(`\n${chalk.bold('Done!')} Opening release in browser...`);
};

const orderCommits = async (commits, tags, exists) => {
Expand Down Expand Up @@ -354,11 +357,11 @@ const checkReleaseStatus = async () => {

const releaseURL = getReleaseURL(existingRelease);

if (releaseURL) {
if (!flags.showUrl && releaseURL) {
open(releaseURL);
}

const alreadyThere = 'Release already exists. Opening in browser...';
const alreadyThere = `Release already exists${flags.showUrl ? `: ${releaseURL}` : '. Opening in browser...'}`;
console.error(`${chalk.red('Error!')} ${alreadyThere}`);

process.exit(1);
Expand Down