Skip to content

Add option to show release URL instead of opening it in the browser#126

Merged
leo merged 4 commits intovercel:masterfrom
mcansh:master
Dec 31, 2018
Merged

Add option to show release URL instead of opening it in the browser#126
leo merged 4 commits intovercel:masterfrom
mcansh:master

Conversation

@mcansh
Copy link
Contributor

@mcansh mcansh commented Apr 23, 2018

closes #120
Signed-off-by: Logan McAnsh logan@mcan.sh

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@timneutkens timneutkens requested a review from leo December 10, 2018 12:37
Copy link
Contributor

@leo leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do --show-url instead? A little more explicit.

@leo
Copy link
Contributor

leo commented Dec 11, 2018

Also: Thank you very much for this change!

@mcansh
Copy link
Contributor Author

mcansh commented Dec 11, 2018

of course! should I use the default shortcut e.g. -s or do you have something else in mind?

mcansh and others added 3 commits December 10, 2018 19:33
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@leo leo changed the title add option to show release URL instead of opening it in the browser Add option to show release URL instead of opening it in the browser Dec 31, 2018
@leo leo merged commit 544e1ba into vercel:master Dec 31, 2018
@leo
Copy link
Contributor

leo commented Dec 31, 2018

Thank you so much!

@Qix-
Copy link

Qix- commented Dec 31, 2018

Not sure how I missed this, but thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for showing URL instead of opening the release in the default browser

3 participants