Skip to content

fix(css): rewrite MiniCssExtractPlugin insert function to ES5 to support legacy browsers #90556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sleitor wants to merge 1 commit into
base: canary
Choose a base branch
from
+14 −3
Open

fix(css): rewrite MiniCssExtractPlugin insert function to ES5 to support legacy browsers #90556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/next/src/build/webpack/config/blocks/css/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,14 +612,25 @@ export const css = curry(async function css(
ignoreOrder: true,
insert: function (linkTag: HTMLLinkElement) {
if (typeof _N_E_STYLE_LOAD === 'function') {
const { href, onload, onerror } = linkTag
// Avoid destructuring and optional-chaining here: this function
// is serialized as a string by mini-css-extract-plugin and
// injected directly into the browser bundle without further
// transpilation. Destructuring (`const { x } = obj`) breaks on
// browsers that pre-date ES2015 support (e.g. Chrome <49).
var href = linkTag.href
var onload = linkTag.onload
var onerror = linkTag.onerror
_N_E_STYLE_LOAD(
href.indexOf(window.location.origin) === 0
? new URL(href).pathname
: href
).then(
() => onload?.call(linkTag, { type: 'load' } as Event),
() => onerror?.call(linkTag, {} as Event)
function () {
if (onload) onload.call(linkTag, { type: 'load' } as Event)
},
function () {
if (onerror) onerror.call(linkTag, {} as Event)
}
)
} else {
document.head.appendChild(linkTag)
Expand Down
Loading