Skip to content

fix: link doesn't scroll to section anchor again (#88986) #89459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kairosci wants to merge 4 commits into
base: canary
Choose a base branch
from
+44 −1
Open

fix: link doesn't scroll to section anchor again (#88986) #89459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cad25d2
fix: link doesn't scroll to section anchor again (#88986)
kairosci Feb 4, 2026
797c001
Merge branch 'canary' into fix-link-anchor-scroll
kairosci Feb 4, 2026
d1ae74d
Merge branch 'canary' into fix-link-anchor-scroll
kairosci Feb 4, 2026
05b7f1c
Merge branch 'canary' into fix-link-anchor-scroll
kairosci Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/next/src/client/components/segment-cache/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,11 @@ export function completeSoftNavigation(
apply: shouldScroll
? segmentPathsToScrollTo !== null
? true
: oldState.focusAndScrollRef.apply
: // Also apply scroll if we have a hash fragment, even if the hash didn't change.
// This allows clicking the same hash link multiple times to scroll each time.
onlyHashChange || (shouldScroll && url.hash !== '')
Copy link
Contributor

@lukesandberg lukesandberg Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldScroll is always true at this point

i think this is equivalent to

 shouldScroll
  ? segmentPathsToScrollTo !== null || onlyHashChange || url.hash !== ''
  : oldState.focusAndScrollRef.apply

Copy link
Author

@kairosci kairosci Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back, it could be a consideration.

yes, my initial goal was to force scroll to true

? true
: oldState.focusAndScrollRef.apply
: oldState.focusAndScrollRef.apply,
onlyHashChange,
hashFragment:
Expand Down
39 changes: 39 additions & 0 deletions test/e2e/app-dir/navigation/navigation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,45 @@ describe('app dir - navigation', () => {
expect(browser.eval('window.pageYOffset')).resolves.toEqual(0)
)
})

it('should scroll to the same hash when clicked multiple times', async () => {
// Test for issue #88986: clicking the same hash link multiple times should scroll each time
const browser = await next.browser('/hash-link-back-to-same-page')

// First click to hash-6
await browser.elementByCss('#link-to-6').click()
await retry(() =>
expect(browser.eval('window.pageYOffset')).resolves.toEqual(114)
)

// Manually scroll down to simulate user scrolling away
await browser.eval('window.scrollBy(0, 500)')
let scrollPos = await browser.eval('window.pageYOffset')
expect(scrollPos).toBeGreaterThan(114)

// Click the same hash link again - should scroll back to hash-6
await browser.elementByCss('#link-to-6').click()
await retry(() =>
expect(browser.eval('window.pageYOffset')).resolves.toEqual(114)
)

// Click hash-50
await browser.elementByCss('#link-to-50').click()
await retry(() =>
expect(browser.eval('window.pageYOffset')).resolves.toEqual(730)
)

// Manually scroll down again
await browser.eval('window.scrollBy(0, 500)')
scrollPos = await browser.eval('window.pageYOffset')
expect(scrollPos).toBeGreaterThan(730)

// Click the same hash link again - should scroll back to hash-50
await browser.elementByCss('#link-to-50').click()
await retry(() =>
expect(browser.eval('window.pageYOffset')).resolves.toEqual(730)
)
})
})

describe('relative hashes and queries', () => {
Expand Down
Loading