fix: link doesn't scroll to section anchor again (#88986)

[kairosci]

Description

Fixes an issue where clicking a link with a hash fragment would not scroll to the target element if clicked multiple times.

Problem

When a user clicks a link with a hash (e.g., <Link href="#section" />) and then scrolls manually away from the target, clicking the same link again would not scroll back to the section. This is because focusAndScrollRef.apply was set to false after the first scroll and was never reset for subsequent navigations to the same hash.

Solution

Modified packages/next/src/client/components/segment-cache/navigation.ts in the completeSoftNavigation function to ensure that when a hash fragment is present in the navigation, the scroll behavior is always applied.

Note: The original fix targeted handle-mutable.ts, but that file was removed in upstream refactor #88046 (commit 8fe154f). The logic was consolidated into the new navigation system. This PR applies the same fix to the current codebase at the correct location.

The fix ensures that when navigating to a URL with a hash fragment (url.hash !== ''), the focusAndScrollRef.apply flag is set to true even if other route segments haven't changed. This handles both cases:

• Clicking different hash links on the same page
• Clicking the same hash link multiple times (e.g., after manual scroll)

Changed File

• packages/next/src/client/components/segment-cache/navigation.ts - Updated the apply logic in focusAndScrollRef to check for hash fragments

Testing

• Existing test: test/e2e/app-dir/navigation/navigation.test.ts (hash-link-back-to-same-page)

Related

Fixes #88986

[lukesandberg]

There appear to be two different changes commingled in this PR

the changes to the link logic and an improvement to the no-html-link-for-pages lint rule, it isn't immediately obvious how these are related.... can you update the PR description to address (or maybe split the lint change into a new PR)

[nextjs-bot]

Allow CI Workflow Run

• approve CI run for commit: 05b7f1c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[kairosci]

Split the changes (which shouldn't have been there in the first place), updated the codebase, readjusted the fix, added the test.

Everything should be OK now, @lukesandberg PTAL.

[lukesandberg]

I patched your PR and observed that the test you added passes without the change to natigation.ts

this matches the observation posted in #88986 (comment)

This appears to have been fixed by #88046 still the test case is useful and i would be happy to accept it

[lukesandberg]

shouldScroll is always true at this point

i think this is equivalent to

 shouldScroll
  ? segmentPathsToScrollTo !== null || onlyHashChange || url.hash !== ''
  : oldState.focusAndScrollRef.apply

[kairosci]

Looking back, it could be a consideration.

yes, my initial goal was to force scroll to true

[kairosci]

So, can I delete fix and remain only the test?