Skip to content

Revert "Fix/zlib mem node"#89322

Merged
bgw merged 1 commit intocanaryfrom
revert-89099-fix/zlib-mem-node
Jan 31, 2026
Merged

Revert "Fix/zlib mem node"#89322
bgw merged 1 commit intocanaryfrom
revert-89099-fix/zlib-mem-node

Conversation

@bgw
Copy link
Member

@bgw bgw commented Jan 30, 2026

Reverts #89099

Apparently this did not solve the other user's memory leak issue: #89091 (comment)

@bgw bgw mentioned this pull request Jan 30, 2026
@bgw bgw enabled auto-merge (squash) January 30, 2026 22:36
@bgw bgw requested review from devjiwonchoi, eps1lon and huozhi and removed request for huozhi January 30, 2026 22:36
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 30, 2026

Tests Passed

@nextjs-bot
Copy link
Collaborator

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁█▁
Cold (Ready in log) 436ms 436ms ▁▁▂█▁
Cold (First Request) 1.159s 1.164s ▁▁▂█▁
Warm (Listen) 456ms 457ms ▁▁▁█▁
Warm (Ready in log) 441ms 445ms ▁▁▁█▁
Warm (First Request) 337ms 337ms ▁▁▂█▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ███▁█
Cold (Ready in log) 439ms 438ms ██▆▆▇
Cold (First Request) 1.754s 1.754s ▄▄▄▃▅
Warm (Listen) 456ms 456ms █▅▁▅▅
Warm (Ready in log) 438ms 437ms ▇▆▅▄▅
Warm (First Request) 1.783s 1.774s ▅▄▄▃▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.958s 3.928s ▁▁▃█▂
Cached Build 3.973s 3.912s ▁▁▃█▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.763s 13.710s ▁▁▂▁▄
Cached Build 13.865s 13.843s ▁▂▂▁▄
node_modules Size 464 MB 464 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **435 kB** → **435 kB** ✅ -6 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 764 B
Total 762 B 764 B ⚠️ +2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B
Total 450 B 450 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 254 B 252 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 55.2 kB -
Total 228 kB 229 kB ⚠️ +693 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 248 kB 249 kB
Total 375 kB 375 kB ⚠️ +412 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 612 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 33.3 kB 33.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.9 kB 34.8 kB ✅ -118 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.8 MB 3.81 MB 🔴 +9.33 kB (+0%)
index.pack gzip 103 kB 103 kB
index.pack.old gzip 102 kB 104 kB 🔴 +2.13 kB (+2%)
Total 4.01 MB 4.02 MB ⚠️ +10.9 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 311 kB
app-page-exp..prod.js gzip 166 kB 166 kB
app-page-tur...dev.js gzip 311 kB 311 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page-tur...dev.js gzip 308 kB 308 kB
app-page-tur..prod.js gzip 164 kB 164 kB
app-page.run...dev.js gzip 308 kB 308 kB
app-page.run..prod.js gzip 164 kB 164 kB
app-route-ex...dev.js gzip 70.5 kB 70.5 kB
app-route-ex..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.1 kB 70.1 kB
app-route-tu..prod.js gzip 48.8 kB 48.8 kB
app-route.ru...dev.js gzip 70.1 kB 70.1 kB
app-route.ru..prod.js gzip 48.7 kB 48.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 39.4 kB 39.4 kB
server.runti..prod.js gzip 62.6 kB 62.6 kB
Total 2.78 MB 2.78 MB ✅ -1 B

@bgw bgw requested a review from lukesandberg January 30, 2026 22:56
@bgw bgw merged commit 9d2d242 into canary Jan 31, 2026
289 of 291 checks passed
@bgw bgw deleted the revert-89099-fix/zlib-mem-node branch January 31, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants