Conversation
…ory leak in Node.js 24
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Collaborator
Tests Passed |
Member
|
@naaa760 I tried re-running the tests a few times in CI (a lot of them are just flaky), but I think this change might be breaking something. A lot of the tests are failing with errors like: |
…void socket hang up
Contributor
Author
|
@bgw |
bgw
approved these changes
Jan 30, 2026
Member
|
Apparently this did not fix the reported issue: #89091 (comment) Reverting in #89322 |
bgw
added a commit
that referenced
this pull request
Jan 31, 2026
Reverts #89099 Apparently this did not solve the user's memory leak issue: #89091 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes zlib memory leak in Node.js 24 when requests are aborted.
Why?
Compression streams weren't cleaned up on abort, causing memory to accumulate.
How?
Destroy the response on request abort/close to clean up compression streams.
Closes NEXT-
fixes: #89091