-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NPM Workspace throwsENOWORKSPACES
error when fetching registry
#68522
Merged
devjiwonchoi
merged 8 commits into
canary
from
08-05-fix_swallow_error_when_fetching_registry
Aug 7, 2024
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7f25ae1
fix: swallow error when fetching registry
devjiwonchoi f26200e
refactor: don't swallow the whole error
devjiwonchoi a49bda9
refactor: do not swallow enoworkspaces error, but try resolve it
devjiwonchoi 3f84b8b
even better flag --no-workspaces
devjiwonchoi 108f749
handle the flag only
devjiwonchoi 70f3cfb
error handling
devjiwonchoi 2436747
refactor: use cause for error instead of inline
devjiwonchoi 50a3518
remove unnecessary err instanceof check
devjiwonchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New implementation has way more confidence given the explainer. This is valueable context, thank you!