Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NPM Workspace throwsENOWORKSPACES error when fetching registry #68522

Merged
merged 8 commits into from
Aug 7, 2024
Merged

fix: NPM Workspace throwsENOWORKSPACES error when fetching registry #68522

merged 8 commits into from
Aug 7, 2024

Commits on Aug 5, 2024

  1. fix: swallow error when fetching registry

    @devjiwonchoi
    devjiwonchoi committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7f25ae1 View commit details
    Browse the repository at this point in the history

  2. refactor: don't swallow the whole error 

    Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
    @devjiwonchoi @eps1lon
    devjiwonchoi and eps1lon committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f26200e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. refactor: do not swallow enoworkspaces error, but try resolve it 

    Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
    @devjiwonchoi @eps1lon
    devjiwonchoi and eps1lon committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a49bda9 View commit details
    Browse the repository at this point in the history

  2. even better flag --no-workspaces

    @devjiwonchoi
    devjiwonchoi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3f84b8b View commit details
    Browse the repository at this point in the history

  3. handle the flag only

    @devjiwonchoi
    devjiwonchoi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    108f749 View commit details
    Browse the repository at this point in the history

  4. error handling

    @devjiwonchoi
    devjiwonchoi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    70f3cfb View commit details
    Browse the repository at this point in the history

  5. refactor: use cause for error instead of inline 

    Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
    @devjiwonchoi @eps1lon
    devjiwonchoi and eps1lon committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2436747 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary err instanceof check

    @devjiwonchoi
    devjiwonchoi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    50a3518 View commit details
    Browse the repository at this point in the history