Skip to content

Fix the bug with creating duplicate components of with-rematch example #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Fix the bug with creating duplicate components of with-rematch example #5440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions examples/with-rematch/shared/utils/withRematch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,12 @@ const getOrCreateStore = (initStore, initialState) => {
export default (...args) => Component => {
// First argument is initStore, the rest are redux connect arguments and get passed
const [initStore, ...connectArgs] = args
// Connect page to redux with connect arguments
const ConnectedComponent = connect.apply(null, connectArgs)(Component)

const ComponentWithRematch = (props = {}) => {
const { store, initialProps, initialState } = props

// Connect page to redux with connect arguments
const ConnectedComponent = connect.apply(null, connectArgs)(Component)

// Wrap with redux Provider with store
// Create connected page with initialProps
return React.createElement(
Expand Down