Fix the bug with creating duplicate components of with-rematch example #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

timneutkens merged 1 commit into vercel:canary from zsxsoft:canary

Oct 12, 2018

Contributor

zsxsoft commented Oct 12, 2018

Fix: #5439
Example: https://github.com/zsxtoys/PoC-nextjs-with-rematch


          Fix the bug with creating duplicate components of with-rematch example

2ac756c

Contributor Author

zsxsoft commented Oct 12, 2018

Sandbox:
without this pr: https://codesandbox.io/s/github/zsxtoys/PoC-nextjs-with-rematch/tree/860ea41818f67f44732858f972280c42f345e33a
with this pr: https://codesandbox.io/s/github/zsxtoys/PoC-nextjs-with-rematch/

timneutkens merged commit 1b8bfc7 into vercel:canary

Member

timneutkens commented Oct 12, 2018

Thanks!

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet