enhancement(data model): Enhance vector protocol for new metric data #6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shape of the metric distribution, histogram, and quantile data has changed internally, requiring them to be reshaped going into and out of the existing vector protocol. This change adds new fields to the metric record that match the new structures, reducing the encoding and decoding overhead. Signed-off-by: Bruce Guenter <bruce@timber.io>
bruceg
added
type: enhancement
bruceg
requested review from
a team,
blt,
JeanMertz and
lukesteensen
and removed request for
a team and
JeanMertz
lukesteensen
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
This looks good to me! It may be worth making a note or opening an issue for once this is released to come back and remove the extra fields/types and mark their tag numbers as reserved. That way we'll have an upgrade path for users but not need to carry this code forever.
|
I think I'll make note of that in a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape of the metric distribution, histogram, and quantile data has
changed internally, requiring them to be reshaped going into and out of
the existing vector protocol. This change adds new fields to the metric
record that match the new structures, reducing the encoding and decoding
overhead.
Signed-off-by: Bruce Guenter bruce@timber.io
Closes #6159