Skip to content

Change license to the MIT license #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2023
Merged

Change license to the MIT license #2738

merged 2 commits into from
Apr 21, 2023

Conversation

@micrommer
Copy link

@micrommer micrommer commented Apr 6, 2023

To resolve #2680 issue.

@micrommer micrommer mentioned this pull request Apr 6, 2023
Closed
danieldietrich
danieldietrich suggested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@danieldietrich danieldietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @micrommer and thank you for your contribution!
The changeset looks really great - you found all spots I can imagine.
I recognized that the two files LICENSE and COPYRIGHT are now identical. Could you please remove the COPYRIGHT file? Do you think it is referenced somewhere else (verbally)?
Thank you!
Daniel

@micrommer
Copy link
Author

micrommer commented Apr 16, 2023

Hi dear @danieldietrich,
It seems the only COPYRIGHT usage was in the Gradle script, you can find the file creation on 2f2304d, Maybe @tobi5775 could confirm the usage.

Best reagards.

@danieldietrich
Copy link
Contributor

danieldietrich commented Apr 20, 2023

@micrommer yes, I can confirm that. Please remove the COPYRIGHT file and change the occurrence in the Gradle script to the LICENSE file.
Thank you

@micrommer
Copy link
Author

micrommer commented Apr 21, 2023

Hi @danieldietrich,
It has already been done in #2738.
Thank you

danieldietrich
danieldietrich approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@danieldietrich danieldietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I am very happy with it! Thx

@danieldietrich danieldietrich merged commit 26181f1 into vavr-io:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danieldietrich danieldietrich danieldietrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change license to MIT

2 participants

@micrommer @danieldietrich