Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node version and dependencies #237

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Update node version and dependencies #237

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26967cc
Update node version and dependencies
therealsujitk Oct 31, 2023
4714334
Add xlsx tests
therealsujitk Oct 31, 2023
cfaf878
Set node version
therealsujitk Oct 31, 2023
3bdb256
Merge branch 'master' into therealsujitk/dependency-updates
therealsujitk Oct 31, 2023
207c981
Support only Node.js 20.x
therealsujitk Oct 31, 2023
9d80179
Temporarily skip failing xlsx test
therealsujitk Oct 31, 2023
a77cc4f
Update required node version
therealsujitk Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: CI
therealsujitk marked this conversation as resolved.
Show resolved Hide resolved

on: [push, pull_request]
therealsujitk marked this conversation as resolved.
Show resolved Hide resolved

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x]
therealsujitk marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile
- run: yarn test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're setting up tests. We can also integrate ESLint here which should check for lint errors and also enforce styling in case pre-commit hook is skipped. Not part of this PR, can be done separately

2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
node_modules
.vscode
dist
.cache
.parcel-cache
src/data/*.json
**/*.DS_Store
util/output*.json
Expand Down
4 changes: 4 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

yarn pretty-quick --staged
vatz88 marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
84 changes: 42 additions & 42 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
# FFCS On The Go
[![Netlify Status](https://img.shields.io/netlify/6d48d2f4-8dc7-4780-ae32-e8da62053826)](https://app.netlify.com/sites/ffcsonthego/deploys) ![Last Update - Vellore](https://img.shields.io/badge/dynamic/json?color=blue&label=vellore&query=$.lastUpdate.vellore&url=https://raw.githubusercontent.com/vatz88/FFCSonTheGo/master/package.json) ![Last Update - Chennai](https://img.shields.io/badge/dynamic/json?color=blue&label=chennai&query=$.lastUpdate.chennai&url=https://raw.githubusercontent.com/vatz88/FFCSonTheGo/master/package.json) [![License](https://img.shields.io/github/license/vatz88/FFCSonTheGo)](/LICENSE.md)
This web application is a tool to visualize your timetable for the students of VIT Vellore & Chennai to help with FFCS course registrations.
![Demo](/demo.gif)
## Links
This application has been deployed at the following links.
- https://ffcsonthego.vatz88.in/ - Currently used
- https://ffcsonthego-archive.vatz88.in/ - Used until **Winter Semester 2018-19**
## Contributing
Anyone and everyone is welcome to contribute. Please take a moment to review our [code of conduct](/.github/CODE_OF_CONDUCT.md).
### Issues
If you've caught a bug or you'd like a new feature to be added, feel free to open an issue so that the same can be discussed.
### Pull Requests
If you're interested in contributing to our code, refer the [contributing guidlines](/.github/CONTRIBUTING.md) before opening a pull request.
## Authors
- **Vatsal Joshi** (Initial work) - [@vatz88](https://github.com/vatz88)
- **Sangeeth Sudheer** - [@sangeeth96](https://github.com/sangeeth96)
## Contributors
- **Sujit Kumar** (Active maintainer) - [@therealsujitk](https://github.com/therealsujitk)
- **Sanket Mohapatra** - [@sanket9918](https://github.com/sanket9918)
See also the list of [contributors](https://github.com/vatz88/FFCSonTheGo/contributors) who participated in this project.
## License
This project is licensed under [the GNU General Public License](/LICENSE.md).
# FFCS On The Go

![CI](https://github.com/vatz88/FFCSonTheGo/actions/workflows/ci.yaml/badge.svg) [![Netlify Status](https://img.shields.io/netlify/6d48d2f4-8dc7-4780-ae32-e8da62053826)](https://app.netlify.com/sites/ffcsonthego/deploys) ![Last Update - Vellore](https://img.shields.io/badge/dynamic/json?color=blue&label=vellore&query=$.lastUpdate.vellore&url=https://raw.githubusercontent.com/vatz88/FFCSonTheGo/master/package.json) ![Last Update - Chennai](https://img.shields.io/badge/dynamic/json?color=blue&label=chennai&query=$.lastUpdate.chennai&url=https://raw.githubusercontent.com/vatz88/FFCSonTheGo/master/package.json) [![License](https://img.shields.io/github/license/vatz88/FFCSonTheGo)](/LICENSE.md)

This web application is a tool to visualize your timetable for the students of VIT Vellore & Chennai to help with FFCS course registrations.

![Demo](/demo.gif)

## Links

This application has been deployed at the following links.

- https://ffcsonthego.vatz88.in/ - Currently used
- https://ffcsonthego-archive.vatz88.in/ - Used until **Winter Semester 2018-19**

## Contributing

Anyone and everyone is welcome to contribute. Please take a moment to review our [code of conduct](/.github/CODE_OF_CONDUCT.md).

### Issues

If you've caught a bug or you'd like a new feature to be added, feel free to open an issue so that the same can be discussed.

### Pull Requests

If you're interested in contributing to our code, refer the [contributing guidlines](/.github/CONTRIBUTING.md) before opening a pull request.

## Authors

- **Vatsal Joshi** (Initial work) - [@vatz88](https://github.com/vatz88)
- **Sangeeth Sudheer** - [@sangeeth96](https://github.com/sangeeth96)

## Contributors

- **Sujit Kumar** (Active maintainer) - [@therealsujitk](https://github.com/therealsujitk)
- **Sanket Mohapatra** - [@sanket9918](https://github.com/sanket9918)

See also the list of [contributors](https://github.com/vatz88/FFCSonTheGo/contributors) who participated in this project.

## License

This project is licensed under [the GNU General Public License](/LICENSE.md).
52 changes: 27 additions & 25 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"vellore": "Winter Semester 2022 (Freshers)",
"chennai": "Winter Semester 2023-24"
},
"main": "index.js",
"repository": "https://github.com/vatz88/FFCSonTheGo.git",
"author": "Vatsal Joshi <vatz88@gmail.com>",
"license": "GPL-3.0",
Expand All @@ -15,36 +14,39 @@
"start:noconvert": "parcel src/index.html",
"build:sw": "workbox generateSW ./src/workbox-config.js",
"build": "yarn convert && parcel build src/index.html && yarn build:sw",
"convert": "node util/convert_xlsx_to_json.js && node util/convert_json_to_data.js"
},
"husky": {
"hooks": {
"pre-commit": "pretty-quick --staged"
}
"convert": "node util/convert_xlsx_to_json.js && node util/convert_json_to_data.js",
"test": "jest tests",
"prepare": "husky install"
},
"engines": {
"node": ">=10 <13"
},
"devDependencies": {
"husky": "^2.4.1",
"parcel-bundler": "^1.12.3",
"prettier": "^1.18.2",
"pretty-quick": "^1.11.1",
"sass": "^1.21.0",
"workbox-cli": "^5.1.3",
"xlsx": "^0.17.0"
"node": ">=18 <21"
therealsujitk marked this conversation as resolved.
Show resolved Hide resolved
},
"browserslist": "> 0.5%, last 2 versions, not dead",
"dependencies": {
"@fortawesome/fontawesome-free": "^5.15.3",
"@popperjs/core": "^2.9.2",
"@sentry/browser": "^5.4.3",
"bootstrap": "^5.0.2",
"@fortawesome/fontawesome-free": "^6.4.2",
"@parcel/core": "^2.10.1",
"@parcel/packager-raw-url": "2.10.1",
"@parcel/transformer-sass": "2.10.1",
"@parcel/transformer-webmanifest": "2.10.1",
"@popperjs/core": "^2.11.8",
"@sentry/browser": "^7.76.0",
"bootstrap": "^5.3.2",
"bootstrap-select": "^1.13.18",
"bootstrap4": "npm:bootstrap@4.6.0",
"date-fns": "^2.28.0",
"date-fns": "^2.30.0",
"easy-autocomplete": "1.3.5",
"html2canvas": "^1.1.4",
"jquery": "3.5.0",
"localforage": "^1.7.3"
"html2canvas": "^1.4.1",
"jquery": "3.7.1",
"localforage": "^1.10.0",
"parcel": "^2.10.1",
"sass": "^1.69.5",
"workbox-cli": "^7.0.0",
"xlsx": "^0.18.5"
},
"devDependencies": {
"husky": "^8.0.0",
"jest": "^29.7.0",
"prettier": "^2.8.8",
"pretty-quick": "^3.1.3"
}
}
Loading
Loading