Update node version and dependencies #237
Conversation
|
@vatz88 the node version will have to be updated for the deploy to succeed. I recommend v20.x. |
|
The CI is failing because of issues with the current report_chennai.xlsx that we overlooked as you can see from the command line output. |
|
@therealsujitk please add a |
|
The update node version and dependencies seem to work fine. The failed tests are the xlsx tests, as you can see it displays all the slots that are missing in the timetable schema. |
|
If you want we can skip the test for now and merge other changes |
.github/workflows/ci.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: yarn install --frozen-lockfile | ||
| - run: yarn test |
There was a problem hiding this comment.
While we're setting up tests. We can also integrate ESLint here which should check for lint errors and also enforce styling in case pre-commit hook is skipped. Not part of this PR, can be done separately
|
All changes implemented except for ESLint. Should be ready to merge now. |
|
We should skip the test to make this pass if we aren't fixing it |
No description provided.