Repository navigation
fix(review): open the Review panel only on explicit user action - #609
Merged
Merged
Conversation
The tool_end handler opened or activated a session's Review tab whenever a workspace Write/Edit succeeded, so an agent edit could reveal the side panel and compete with whatever the user was reading. Remove the artifact gate and its helper so a tool result never opens, activates, or resizes the panel. The message-owned inline review card still records the change in the transcript, and Review stays reachable from the "+" launcher row and from the retained panel context the viewport toggle reveals. Specs, E2E scenarios, and the decisions log (D451) follow the behavior.
The locale check compares table and fence structure between the English specifications and their Chinese mirrors, so D451 has to exist on both sides, and the reworded Review trigger sentences now agree instead of describing the removed automatic panel opening. No behavior change in this commit.
This was referenced Sep 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A successful workspace
Write/Editused to open or activate the session'sReview tab from the
tool_endhandler, so an agent edit could reveal the sidepanel and compete with whatever the user was reading. The artifact gate
(
shouldOpenReviewArtifact) and its call site are removed: no tool resultopens, activates, or resizes the work panel.
Review now stays reachable only through explicit user actions — the
+Newlauncher row and the retained panel context the viewport-fixed toggle /
Cmd/Ctrl + Jreveals. The message-owned inline review card still records thechange in the transcript, and hash-guarded rollback is unchanged.
Verification
apps/desktop:node --test test/*.test.mjs→ 2209 passed, 0 failed on thiscommit against
origin/mainbfe44b5.remains (
work-panel.test.mjs,bundled-plugins.test.mjs,chat-review-entry.test.mjs).tsc -p apps/desktop/tsconfig.json --noEmit: no error in any changed file.The remaining prompt-enhancement errors come from a stale local
@pi-desktop/shareddist, not from this change.Specs
04-ux/01-ui-ia.md,04-ux/08-component-spec.md§5.4,04-ux/09-interaction-patterns.md,04-ux/10-workbuddy-benchmark-ux.md,06-delivery/04-e2e-test-plan.md(E2E-057, E2E-153, US-UI-68), and08-meta/decisions-log.mdD451.