Repository navigation
feat(i18n): name the two plugin extension kinds distinctly (#998 item 4) - #1427
Open
Blue-Berrys wants to merge 2 commits into
Open
Blue-Berrys wants to merge 2 commits into
Blue-Berrys wants to merge 2 commits into
Conversation
…item 4) Capability chips said "Panel" and "Work panel view(s)" — two phrases too close to tell apart on screen, though the two contributions behave differently: `ui.panel` opens a separate floating window, while `contributes.views` docks a tab into the work panel. The two labels now state that difference in every locale: a standalone panel window versus a side panel view. Values only; no key changes.
muzimu217
reviewed
Oct 6, 2026
muzimu217
left a comment
muzimu217
left a comment
Contributor
There was a problem hiding this comment.
Verified locally on the PR branch: pnpm -C packages/i18n test passes (29/29, including the renderer-keys and catalogs completeness checks).
Checked the terminology against the code it names:
panel↔PluginUiMeta(packages/shared/src/types/plugins.ts:73): the plugin's own OS window with width/height/title and theshape: "panel" | "widget"placement — "Standalone panel window" is accurate.views↔PluginViewMeta/ the<pluginId>/<viewId>work-panel tab resource: docked side-panel views — "Side panel view" is accurate.
All 9 locales covered (the repo has exactly these locales; no ja to miss), keys unchanged, values only. The new labels also disambiguate the pair better than "Panel" vs "Work panel views" did, which matters now that #1429 lists panels in the New launcher next to views.
No blockers from me.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #998, item 4. The capability chips said "Panel" and "Work panel view(s)" — two phrases too close to tell apart on screen, though the two contributions behave differently:
ui.panelopens a separate floating window, whilecontributes.viewsdocks a tab into the side work panel. The issue's author could not tell from the UI where a plugin would appear, and the same confusion applies to anyone reading a row.Changes
Values only, no keys — every locale renames the two capability labels to state the behavior:
panelviewsThese labels surface wherever capability chips do (installed rows, market rows and their row details). The
ui.panelpermission chip ("Show plugin panel") is a separate key and keeps its wording.Verification
packages/i18ntypecheck — the<satisfies EnglishCatalog>key structure still passes for all nine locales; values-only changes.packages/i18ntest suite — 29 passed (catalogs, renderer-keys against the desktop sources, user-facing-copy).tsc --noEmit— clean.Partially addresses #998; items 2 and 6 remain follow-ups.