Skip to content

feat(graphql-java-client-validator-plugin) S3671: added test yaml fil… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ukondoz
Copy link
Collaborator

@ukondoz ukondoz commented Jul 3, 2023

Summary

Using workflow in github actions to test, build and publish maven plugin .

Notes for PR Reviewers

n/a

References

n/a

Limitations

n/a

How Has This Been Tested?

No test file has added. Just added yaml files and check the github actions.

Checklist:

To Raise Draft PR

  • My PR Title follows the format type(scope)[!]: Ref: Brief Title
  • My code meets all style guidelines / linting checks etc.
  • I have performed a self-review of my code.
  • I have commented my code and made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Before Final Review

  • I have created a draft PR free of merge conflicts and verified behaviour in a review environment.
  • All errors and warnings in the review environment have been addressed.

Reviewer Checklist

  • I have been able to build and run the PR locally.optional
  • I have verified that the change works as intended in the review environment

Shout-outs:

[ @ anyone else here who may not need to be a reviewer, but should be notified. ]

Support Notes:

[Special instructions for troubleshooting should things go wrong while the author is unavailable]

@ukondoz ukondoz added the WIP Work in progress not ready to merge label Jul 3, 2023
@ukondoz ukondoz force-pushed the ukondoz/S3671-publish-graphql-maven-plugin branch 7 times, most recently from d575d62 to 91eb45f Compare July 4, 2023 16:24
@ukondoz ukondoz removed the WIP Work in progress not ready to merge label Jul 4, 2023
@ukondoz ukondoz force-pushed the ukondoz/S3671-publish-graphql-maven-plugin branch from 91eb45f to 8dbea66 Compare July 5, 2023 08:04
@ukondoz ukondoz force-pushed the ukondoz/S3671-publish-graphql-maven-plugin branch from 8dbea66 to 6c241a3 Compare July 5, 2023 08:56
Copy link

@aaronbate aaronbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment on the README

…d yaml file to trigger the test, build actions and then publish the package
@ukondoz ukondoz force-pushed the ukondoz/S3671-publish-graphql-maven-plugin branch from 6c241a3 to c90392a Compare July 5, 2023 10:31
@ukondoz ukondoz merged commit 15b3cc8 into main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants