Skip to content

Commit 15b3cc8

Browse files
authored
feat(graphql-java-client-validator-plugin) S3671: added test yaml fil… (#3)
## Summary Using workflow in github actions to test, build and publish maven plugin. ### Notes for PR Reviewers n/a ## References n/a ## Limitations n/a # How Has This Been Tested? No test file has added. Just added yaml files and check the github actions. # Checklist: ## To Raise Draft PR - [ ] My PR Title follows the format type(scope)[!]: Ref: Brief Title - [ ] My code meets all style guidelines / linting checks etc. - [ ] I have performed a self-review of my code. - [ ] I have commented my code and made corresponding changes to the documentation. - [ ] My changes generate no new warnings. - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] New and existing unit tests pass locally with my changes. ## Before Final Review - [ ] I have created a draft PR free of merge conflicts and verified behaviour in a review environment. - [ ] All errors and warnings in the review environment have been addressed. ## Reviewer Checklist - [ ] I have been able to build and run the PR locally.*optional* - [ ] I have verified that the change works as intended in the review environment ### Shout-outs: [ @ anyone else here who may not need to be a reviewer, but should be notified. ] ### Support Notes: [Special instructions for troubleshooting should things go wrong while the author is unavailable]
1 parent de27497 commit 15b3cc8

File tree

5 files changed

+120
-2
lines changed

5 files changed

+120
-2
lines changed

.github/pull_request_template.md

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
## Summary
2+
3+
[ a brief summary of your changes ]
4+
5+
[Note that the Title should follow the format **type(scope)[Breaking indicator !]: Ref: Brief Title** ]
6+
7+
[e.g. *feat(orders)!: S1234: investor orders api now structured in hiarachical format to include trading orders*]
8+
9+
[For guidence on the convention please check https://www.conventionalcommits.org/en/v1.0.0/#summary]
10+
11+
### Notes for PR Reviewers
12+
13+
[ What should they be on the lookout for? ]
14+
15+
[ Did you make any notable design decisions as a result of this change that they should know about? ]
16+
17+
## References
18+
19+
[ What Additional Stories/Defects are resolved by this PR (not referenced in title)]
20+
21+
## Limitations
22+
[ Are there any known limitations? Or aspects of the story(s) that will be delivered in a subsequent PR? ]
23+
24+
# How Has This Been Tested?
25+
26+
Summarize tests added and instructions to run.
27+
If no new tests were added/required please state why.
28+
29+
[List of tests - or link to test collateral]
30+
- [ ] Test A
31+
- [ ] Test B
32+
33+
34+
# Checklist:
35+
36+
## To Raise Draft PR
37+
38+
- [ ] My PR Title follows the format type(scope)[!]: Ref: Brief Title
39+
- [ ] My code meets all style guidelines / linting checks etc.
40+
- [ ] I have performed a self-review of my code.
41+
- [ ] I have commented my code and made corresponding changes to the documentation.
42+
- [ ] My changes generate no new warnings.
43+
- [ ] I have added tests that prove my fix is effective or that my feature works.
44+
- [ ] New and existing unit tests pass locally with my changes.
45+
46+
## Before Final Review
47+
48+
- [ ] I have created a draft PR free of merge conflicts and verified behaviour in a review environment.
49+
- [ ] All errors and warnings in the review environment have been addressed.
50+
51+
## Reviewer Checklist
52+
53+
- [ ] I have been able to build and run the PR locally.*optional*
54+
- [ ] I have verified that the change works as intended in the review environment
55+
56+
### Shout-outs:
57+
58+
[ @ anyone else here who may not need to be a reviewer, but should be notified. ]
59+
60+
### Support Notes:
61+
62+
[Special instructions for troubleshooting should things go wrong while the author is unavailable]

.github/workflows/build.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
name: Build and Deploy
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
8+
jobs:
9+
publish:
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v3
13+
- uses: actions/setup-java@v3
14+
with:
15+
java-version: '17'
16+
distribution: 'temurin'
17+
- name: Build
18+
run: mvn --batch-mode --update-snapshots package
19+
- name: Publish
20+
run: mvn --batch-mode deploy
21+
env:
22+
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.github/workflows/test.yaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Test
2+
3+
on:
4+
push:
5+
pull_request:
6+
branches:
7+
- main
8+
9+
jobs:
10+
test:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v3
14+
- uses: actions/setup-java@v3
15+
with:
16+
java-version: '17'
17+
distribution: 'temurin'
18+
- name: Test
19+
run: mvn --batch-mode --update-snapshots test

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,11 @@ USAGE :
5656
</clientClasses>
5757
</configuration>
5858
</plugin>
59-
```
59+
```
60+
61+
62+
MERGING PRs:
63+
----------------
64+
After each merge to main, the package is built and an attempt is made to release to the Github Java Repository. This only succeeds where the version does not already exist in the repo.
65+
66+
Please make sure the version is increased in the `pom.xml` file before every merge to main.

pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<modelVersion>4.0.0</modelVersion>
66
<groupId>com.valstro.plugin</groupId>
77
<artifactId>graphql-java-client-validator-plugin</artifactId>
8-
<version>0.0.1-SNAPSHOT</version>
8+
<version>0.0.1</version>
99
<name>graphql-java-client-validator-plugin</name>
1010
<packaging>maven-plugin</packaging>
1111

@@ -153,4 +153,12 @@
153153
</plugin>
154154
</plugins>
155155
</reporting>
156+
157+
<distributionManagement>
158+
<repository>
159+
<id>github</id>
160+
<name>GitHub Packages</name>
161+
<url>https://maven.pkg.github.com/valstro/graphql-java-client-validator-plugin</url>
162+
</repository>
163+
</distributionManagement>
156164
</project>

0 commit comments

Comments
 (0)