Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): revert filter functionality #5651

Conversation

IraErshova
Copy link
Contributor

Revert filter functionality to allow developers to implement their own

Close #5624

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • [] added/updated API documentation.
  • added/updated demos.

Revert filter functionality to allow developers implement their own

Close valor-software#5624
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #5651 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5651   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc365e...2f7ddfc. Read the comment docs.

@dmitry-zhemchugov
Copy link
Contributor

Tested but needs approval

@dmitry-zhemchugov dmitry-zhemchugov removed their assignment Feb 7, 2020
@daniloff200 daniloff200 merged commit ff361a4 into valor-software:development Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeahead async results don't show since 5.5.0 (because of re-filtering)
3 participants