feat(typeahead): add sort functionality to typeahead #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IraErshova
force-pushed
the
feat-typeahead-order-result
branch
2 times, most recently
from
403b016
to
b7595a5
Compare
daniloff200
previously approved these changes
Feb 6, 2020
daniloff200
reviewed
Feb 6, 2020
| @@ -402,7 +408,7 @@ export class TypeaheadDirective implements OnInit, OnDestroy { | |||
| ); | |||
| }) | |||
| ) | |||
| .subscribe((matches: TypeaheadMatch[]) => { | |||
| .subscribe((matches: any[]) => { | |||
There was a problem hiding this comment.
according to chat with @IraErshova , there will be separate PR for fix of types in typeahead, because, this TypeaheadMatch type here was not exactly correct
There was a problem hiding this comment.
Thanks for your comment!
5 tasks
Codecov Report
@@ Coverage Diff @@
## development #5646 +/- ##
============================================
Coverage 52.52% 52.52%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 52 52
Misses 37 37
Partials 10 10Continue to review full report at Codecov.
|
IraErshova
force-pushed
the
feat-typeahead-order-result
branch
from
e06c226
to
44ba5fc
Compare
IraErshova
added
ready for review
ready for tests
and removed
needs review
needs: tests
labels
|
@IraErshova Needs clarification regarding the name of Demo and classes |
Add sort functionality to typeahead Close valor-software#4808
IraErshova
force-pushed
the
feat-typeahead-order-result
branch
from
2437736
to
952be76
Compare
@dmitry-zhemchugov I fixed this |
daniloff200
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort functionality to typeahead
Close #4808
This PR depends on #5651
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.