Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): add method to change modal window class #4811

Merged
merged 12 commits into from
Dec 7, 2018
Merged

feat(modal): add method to change modal window class #4811

merged 12 commits into from
Dec 7, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2018 •
edited by ghost
Loading

Was added:

  • demo Change class
  • functionality for changing modal's window class after the modal window was opened

joxi_screenshot_1542299975482

Related to #2824

@ghost ghost added the needs review label Nov 15, 2018
Domainv
Domainv previously approved these changes Nov 16, 2018
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 16, 2018 •
edited
Loading

Codecov Report

Merging #4811 into development will increase coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #4811      +/-   ##
==============================================
+ Coverage        74.51%   74.7%   +0.19%     
==============================================
  Files              273     276       +3     
  Lines             8365    8381      +16     
  Branches          1594    1594              
==============================================
+ Hits              6233    6261      +28     
+ Misses            1696    1681      -15     
- Partials           436     439       +3
Impacted Files Coverage Δ
src/modal/bs-modal.service.ts 22.42% <0%> (-0.43%) ⬇️
src/modal/bs-modal-ref.service.ts 60% <0%> (-15%) ⬇️
src/chronos/i18n/pl.ts 69.23% <0%> (-2.57%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️
src/modal/index.ts 100% <0%> (ø)
src/modal/modal-backdrop.options.ts 50% <0%> (ø)
src/modal/public_api.ts 100% <0%> (ø)
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc77f8...3fd2a22. Read the comment docs.

@ghost ghost assigned Domainv Nov 16, 2018
@Domainv
Copy link
Contributor

Domainv commented Nov 20, 2018

needs add tests

@ghost ghost added the needs review label Nov 26, 2018
@ghost ghost force-pushed the model-change-config branch 6 times, most recently from e4efe9b to 494edce Compare November 27, 2018 11:03
@ghost ghost force-pushed the model-change-config branch from 494edce to 9bcc762 Compare November 27, 2018 11:20
@ghost ghost force-pushed the model-change-config branch from 9bcc762 to 8a3ad95 Compare November 27, 2018 12:10
@ghost ghost force-pushed the model-change-config branch from 744b344 to 336ded3 Compare November 27, 2018 12:42
@ghost ghost force-pushed the model-change-config branch from 336ded3 to 67f9840 Compare November 27, 2018 13:57
@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018
@ghost ghost assigned ludmilanesvitiy Dec 6, 2018
@ludmilanesvitiy
Copy link
Contributor

screenshot from 2018-12-06 12-31-44
This is a view from FF 63.0.3
Need to fix button view for FF (should be centered or aligned to width as in Chrome)

@ghost
Copy link
Author

ghost commented Dec 6, 2018

can't reproduce
joxi_screenshot_1544112709783

@ludmilanesvitiy
Copy link
Contributor

Retested with different FF versions and diff OS, looks good.

@valorkin valorkin merged commit 2fcdd7f into valor-software:development Dec 7, 2018
@ghost ghost removed the ready for merge label Dec 7, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@leo6104
feat(modal): add method to change modal window class (valor-software#…
8495f89 
…4811)

Fixes valor-software#2824

* fix(test): increase code coverage

* Update modal-backdrop.component.spec.ts

* feat(modal-backdrop): added tests to modal-backdrop component

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* fix(files): clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Domainv Domainv

@ludmilanesvitiy ludmilanesvitiy

Labels
comp(modal)
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Domainv @ludmilanesvitiy @valorkin