Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): add possibility of dynamic changing class of a modal when using BsModalRef #2824

Closed
Alpha0723 opened this issue Oct 12, 2017 · 3 comments
Closed

feat(modal): add possibility of dynamic changing class of a modal when using BsModalRef #2824

Alpha0723 opened this issue Oct 12, 2017 · 3 comments
Labels
comp(modal) effort1: easy (hours) feat-request

Comments

@Alpha0723
Copy link

Alpha0723 commented Oct 12, 2017 •
edited
Loading

I am using BsModalRef to show dialog. In the dialog, I implement a setting guideline step by step, but in each step, I need to set different 'width'. I find I only can pass param {class: 'my-dialog-class'} when calling BsModalRef.show(). So how can I dynamic set different width or class on the dialog in each step?
@IlyaSurmay
Copy link
Contributor

ngx-bootstrap doesn't provide this functionality for now :(
Nice reason for a small PR though.

@YevheniiaMazur YevheniiaMazur changed the title How to dynamic change class of a modal when using BsModalRef feat(modal): add possibility of dynamic changing class of a modal when using BsModalRef Jan 15, 2018
@EvilAlexei EvilAlexei mentioned this issue Jan 15, 2018
Closed
37 tasks
@polaris327
Copy link

Guys! Any updates on this yet?

@ghost
Copy link

ghost commented Nov 12, 2018 •
edited by ghost
Loading

@Alpha0723 @polaris327 Maybe this code helps you

@ghost ghost mentioned this issue Nov 15, 2018
Merged
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this issue Oct 10, 2019
@leo6104
feat(modal): add method to change modal window class (valor-software#…
8495f89 
…4811)

Fixes valor-software#2824

* fix(test): increase code coverage

* Update modal-backdrop.component.spec.ts

* feat(modal-backdrop): added tests to modal-backdrop component

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* Update modal-backdrop.component.spec.ts

* fix(files): clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(modal) effort1: easy (hours) feat-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Alpha0723 @Domainv @polaris327 @IlyaSurmay @YevheniiaMazur