fix(weeks): change calculation of week number #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ngv4 #2368 +/- ##
==========================================
+ Coverage 64.84% 64.93% +0.09%
==========================================
Files 137 137
Lines 4230 4224 -6
Branches 677 677
==========================================
Hits 2743 2743
+ Misses 1241 1235 -6
Partials 246 246
Continue to review full report at Codecov.
|
vvpanchenko
force-pushed
the
fix-week-number
branch
2 times, most recently
from
671c5ea to
80dbe3e
Compare
vvpanchenko
force-pushed
the
fix-week-number
branch
2 times, most recently
from
57fcd13 to
eeeb6ca
Compare
|
Updated, resolved issue with the end of the year. first last week number |
vvpanchenko
force-pushed
the
fix-week-number
branch
from
eeeb6ca to
1ac6158
Compare
|
Will be cleaned up and squashed tomorrow morning |
vvpanchenko
changed the title
vvpanchenko
force-pushed
the
fix-week-number
branch
2 times, most recently
from
67eaa10 to
3d258cc
Compare
vvpanchenko
changed the title
|
Please, take a look at this behavior: https://stackoverflow.com/questions/32120122/difference-between-week-of-year-and-week-of-year-iso-tokens-moment-js |
vvpanchenko
force-pushed
the
fix-week-number
branch
from
3d258cc to
d18ef97
Compare
valorkin
approved these changes
Aug 9, 2017
|
@vvpanchenko give it to @SergeyKuryatnick for testing |
|
Already, it was in testing about an hour ago, will ask for updating status |
valorkin
approved these changes
Aug 16, 2017
valorkin
added a commit
that referenced
this pull request
Sep 14, 2017
…2602) BREAKING CHANGES: - dropped support of ng v2 * feat(package): upgrading ng v4 * feat(package): dropped support of ng v2 * chore(datepicker): initial commit * chore(package): beta.6 * fix(datepicker): for ng v4 * chore(core): after merge fix * fix(demo): fix carousel demo error * fix(tests): add matchers, fix fn output type in draggable service * chore(package): upgraded angular dependencies * 2.0.0-beta.3 * chore(changelog): update * chore(package): fixed missing moment dependecy * fix(index.ts): fix merge issue in root index.ts (#2357) - Removed duplicate export * fix(weeks): change calculation of week number (#2368) * feat(package): theme switching upgraded * chore(package): version bump * chore(package): we need more dependencies * chore(package): prettier applied * chore(package): splitted html from .ts components * chore(package): applying tslint * chore(package): tslint apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.