Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): drop support of ng v2 and add support of ng v4 and v5 #2602

Merged
merged 29 commits into from
Sep 14, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Sep 8, 2017

No description provided.

valorkin and others added 21 commits March 30, 2017 23:43
Conflicts:
	demo/src/app/components/+datepicker/demo-datepicker.module.ts
	package.json
	src/package.json
Conflicts:
	package.json
	src/index.ts
	src/package.json
	src/typeahead/index.ts
	src/typeahead/latin-map.ts
	src/typeahead/typeahead-utils.ts
	src/typeahead/typeahead.directive.ts
Conflicts:
	demo/src/app/components/+tabs/demos/basic/basic.html
	package.json
	src/component-loader/component-loader.class.ts
	src/spec/ng-bootstrap/popover.spec.ts
	src/spec/ng-bootstrap/tooltip.spec.ts
Conflicts:
	demo/src/app/components/+datepicker/datepicker-section.component.ts
	demo/src/app/components/+datepicker/demo-datepicker.module.ts
	demo/src/app/components/+datepicker/demos/index.ts
	demo/src/ng-api-doc.ts
	package.json
Conflicts:
	demo/src/app/components/+datepicker/demos/bs-popup/date-picker-popup.ts
	package.json
	tslint.json
@valorkin valorkin self-assigned this Sep 8, 2017
@valorkin valorkin added the WIP label Sep 8, 2017
@fchiumeo
Copy link

fchiumeo commented Sep 8, 2017

feat(package): drop support of ng v4 and add support of ng v5
you mean
feat(package): drop support of ng v2 and add support of ng v4 ?

@valorkin valorkin changed the title feat(package): drop support of ng v4 and add support of ng v5 feat(package): drop support of ng v2 and add support of ng v4 and v5 Sep 8, 2017
@valorkin
Copy link
Member Author

valorkin commented Sep 8, 2017

@fchiumeo indeed :) thanks, seems it's enough for today

@codecov
Copy link

codecov bot commented Sep 11, 2017

Codecov Report

Merging #2602 into development will increase coverage by 4.62%.
The diff coverage is 58.27%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2602      +/-   ##
===============================================
+ Coverage        65.99%   70.62%   +4.62%     
===============================================
  Files              182      136      -46     
  Lines             5011     4112     -899     
  Branches           790      725      -65     
===============================================
- Hits              3307     2904     -403     
+ Misses            1391      908     -483     
+ Partials           313      300      -13
Impacted Files Coverage Δ
src/buttons/button-radio.directive.ts 94.87% <ø> (ø) ⬆️
src/accordion/accordion.component.ts 90% <ø> (ø) ⬆️
src/component-loader/content-ref.class.ts 100% <ø> (ø) ⬆️
src/bs-moment/locale/locale.defaults.ts 100% <ø> (ø) ⬆️
src/bs-moment/utils/date-getters.ts 22.22% <0%> (-2.03%) ⬇️
src/bs-moment/utils/start-end-of.ts 73.68% <0%> (ø) ⬆️
src/collapse/collapse.module.ts 83.33% <0%> (-16.67%) ⬇️
src/buttons/buttons.module.ts 85.71% <0%> (-14.29%) ⬇️
src/datepicker/datepicker.module.ts 92.3% <0%> (-7.7%) ⬇️
src/bs-moment/units/second.ts 100% <100%> (ø) ⬆️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101fb20...2d7f63f. Read the comment docs.

@IlyaSurmay IlyaSurmay added this to the v2.0.0 milestone Sep 14, 2017
@valorkin valorkin merged commit 31c5f62 into development Sep 14, 2017
steelsojka added a commit to steelsojka/ngx-bootstrap that referenced this pull request Sep 14, 2017
…ootstrap into development

* 'development' of https://github.com/valor-software/ngx-bootstrap:
  fix(modals): fix issues with renderer2 in modal service
  fix(dropdown): prevent event propogation if dropdown toggle clicked
  fix(datepicker): added zindex to show datepicker above input fields
  fix(tests): fixed tests, change renderer to renderer2
  fix(dropdown): fix ngv4 dropdowns (valor-software#2644)
  fix(tabs): fix default tab selection (valor-software#2643)
  feat(timepicker): replace glyphicons with custom icons (valor-software#2640)
  fix(modal): fix bsModalRef paths in demos (valor-software#2638)
  feat(rating): remove glyphicons, add custom template support (valor-software#2631)
  fix(datepicker): fix long date format (valor-software#2630)
  feat(moment-ts): added czech locale (valor-software#2642)
  feat(package): drop support of ng v2 and add support of ng v4 and v5 (valor-software#2602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants