Enable USE_LIBBACKTRACE Across CI and Fix Alpine Builds#3213
Merged
zuiderkwast merged 2 commits intovalkey-io:unstablefrom Feb 16, 2026
Merged
Enable USE_LIBBACKTRACE Across CI and Fix Alpine Builds#3213zuiderkwast merged 2 commits intovalkey-io:unstablefrom
zuiderkwast merged 2 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
dvkashapov
approved these changes
Feb 16, 2026
sarthakaggarwal97
approved these changes
Feb 16, 2026
rainsupreme
approved these changes
Feb 16, 2026
Contributor
rainsupreme
left a comment
rainsupreme
left a comment
There was a problem hiding this comment.
LGTM, and thanks for getting this! Is there a way I should have tested these before committing the change? 😅
Contributor
|
@rainsupreme yes it could have been detected by running daily test in your forked repo. |
zuiderkwast
approved these changes
Feb 16, 2026
Contributor
|
@Nikhil-Manglore please address the conflicts when you have time |
Contributor
|
I just gave you a small merge conflict by merging #3202 first. Sorry for that. |
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Member
Author
|
Thanks, fixed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3213 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
This PR enables `USE_LIBBACKTRACE=yes` across all CI builds and builds upon the changes introduced in valkey-io#3034. Alpine-based jobs previously attempted to install `libbacktrace-dev`, which does not exist in Alpine’s apk repositories. This caused these two errors in the daily tests below: - https://github.com/valkey-io/valkey/actions/runs/22045858351/job/63694456995 - https://github.com/valkey-io/valkey/actions/runs/22045858351/job/63694457018 To resolve this, Alpine jobs now build GNU libbacktrace from source inside the container before compiling Valkey. This aligns Alpine behavior with other environments (Ubuntu jobs) and now avoids utilizing non-existent Alpine packages. An alternative approach we can consider is to disable `USE_LIBBACKTRACE` for Alpine-based tests. Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
USE_LIBBACKTRACE=yesacross all CI builds and builds upon the changes introduced in #3034. Alpine-based jobs previously attempted to installlibbacktrace-dev, which does not exist in Alpine’s apk repositories.This caused these two errors in the daily tests below:
To resolve this, Alpine jobs now build GNU libbacktrace from source inside the container before compiling Valkey. This aligns Alpine behavior with other environments (Ubuntu jobs) and now avoids utilizing non-existent Alpine packages.
An alternative approach we can consider is to disable
USE_LIBBACKTRACEfor Alpine-based tests.