Label is not removed automatically after extra tests are completed#3202
Merged
zuiderkwast merged 1 commit intovalkey-io:unstablefrom Feb 16, 2026
Merged
Conversation
Contributor
|
For reference, it's a follow-up and partial revert of: |
zuiderkwast
reviewed
Feb 13, 2026
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Good job. Looking back at what we added in #2907, I think we can revert some of that, such as the changes to repository and ref for actions/checkout.
Contributor
|
Please fix the merge conflict. Then I want to merge it. |
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
run-extra-tests-on-label
branch
from
7bc8416 to
aac06d5
Compare
Contributor
Author
|
@zuiderkwast done! |
zuiderkwast
approved these changes
Feb 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3202 +/- ##
================================
================================
🚀 New features to boost your workflow:
|
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…alkey-io#3202) We made some changes to the workflow where the label was getting removed every time we ran it. This changes handles it, removes `pull_request_target` and doesn't re-trigger on adding another label. I tried it here: sarthakaggarwal97#65 The code is already merged in my unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made some changes to the workflow where the label was getting removed every time we ran it. This changes handles it, removes
pull_request_targetand doesn't re-trigger on adding another label.I tried it here: sarthakaggarwal97#65
The code is already merged in my unstable.