Fixing Weekly Tests Workflow on Released Branches#3045
Merged
madolson merged 1 commit intovalkey-io:unstablefrom Jan 12, 2026
Merged
Fixing Weekly Tests Workflow on Released Branches#3045madolson merged 1 commit intovalkey-io:unstablefrom
madolson merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3045 +/- ##
============================================
- Coverage 74.25% 74.17% -0.08%
============================================
Files 129 129
Lines 70988 70988
============================================
- Hits 52712 52656 -56
- Misses 18276 18332 +56 🚀 New features to boost your workflow:
|
roshkhatri
approved these changes
Jan 12, 2026
Member
roshkhatri
left a comment
roshkhatri
left a comment
There was a problem hiding this comment.
LGTM, this would allow the weekly wf to run the daily.yml
Nikhil-Manglore
approved these changes
Jan 12, 2026
madolson
approved these changes
Jan 12, 2026
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
The patch fixes the error by adding `pull‑requests: write` to the permissions block of `weekly.yml`. Github rejects if the reusable workflow's (here daily.yml) permissions are not provided. We recently changed the permissions in `daily.yml` where we gave write permissions in valkey-io#2907 With this change, we bring parity to the permissions since `weekly.yml` uses calls `daily.yml` workflow call method. Fixes: https://github.com/valkey-io/valkey/actions/runs/20890545320 Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch fixes the error by adding
pull‑requests: writeto the permissions block ofweekly.yml. Github rejects if the reusable workflow's (here daily.yml) permissions are not provided.We recently changed the permissions in
daily.ymlwhere we gave write permissions in #2907With this change, we bring parity to the permissions since
weekly.ymluses callsdaily.ymlworkflow call method.Fixes: https://github.com/valkey-io/valkey/actions/runs/20890545320