Weekly Test Runs on Released Branches#2702
Conversation
0de885f to
4622032
Compare
roshkhatri
left a comment
There was a problem hiding this comment.
I think we should prefer to use github workflow actions more than relying on APIs
hpatro
left a comment
There was a problem hiding this comment.
Could you run it in your fork and share the run link here? Would like to visualize it.
@roshkhatri mentioned the daily runs on active PR against release branch. Do they conflict with each other or they just run in queued manner.
8691d22 to
03c3d04
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2702 +/- ##
============================================
+ Coverage 74.29% 74.31% +0.01%
============================================
Files 129 129
Lines 70974 70974
============================================
+ Hits 52731 52744 +13
+ Misses 18243 18230 -13 🚀 New features to boost your workflow:
|
769325d to
050f73c
Compare
|
@hpatro @roshkhatri I added a link in the PR description to visualize the test.
They run in a queued manner. |
|
Can you also add screen shots of the workflow runs as an example in the top comment?? |
|
@roshkhatri there is a link in the top comment to display how it looks like. |
|
@madolson please help review whenever you get a chance! Thank you! |
|
@madolson are we good to merge this? |
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
45a2e7c to
403b6e1
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Resolves: valkey-io#2228 Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295 Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches. The PR adds support for running weekly tests on already released versions `>= 7.2`. The workflow will execute the "daily" test workflow for each of these branches on `Sunday 06:00 UTC`. The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners). --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
|
@sarthakaggarwal97 This doesn't seem to have run for some reason, https://github.com/valkey-io/valkey/actions/workflows/daily.yml, can you take a look? |
|
yeah, it was run but looks like some permission issue. Both of my PRs probably had conflict of permissions. |
|
I am taking a look. |
|
Raised a PR fix: #3045 |
Resolves: valkey-io#2228 Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295 Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches. The PR adds support for running weekly tests on already released versions `>= 7.2`. The workflow will execute the "daily" test workflow for each of these branches on `Sunday 06:00 UTC`. The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners). --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Resolves: #2228
Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295
Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches.
The PR adds support for running weekly tests on already released versions
>= 7.2. The workflow will execute the "daily" test workflow for each of these branches onSunday 06:00 UTC.The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners).