Skip to content

Weekly Test Runs on Released Branches#2702

Merged
madolson merged 2 commits intovalkey-io:unstablefrom
sarthakaggarwal97:weekly-release-daily-tests
Jan 6, 2026
Merged

Weekly Test Runs on Released Branches#2702
madolson merged 2 commits intovalkey-io:unstablefrom
sarthakaggarwal97:weekly-release-daily-tests

Conversation

@sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Oct 7, 2025

Resolves: #2228

Visualization: https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295

Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches.

The PR adds support for running weekly tests on already released versions >= 7.2. The workflow will execute the "daily" test workflow for each of these branches on Sunday 06:00 UTC.

The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners).

Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should prefer to use github workflow actions more than relying on APIs

Copy link
Contributor

@hpatro hpatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run it in your fork and share the run link here? Would like to visualize it.

@roshkhatri mentioned the daily runs on active PR against release branch. Do they conflict with each other or they just run in queued manner.

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch 2 times, most recently from 8691d22 to 03c3d04 Compare October 10, 2025 01:01
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.31%. Comparing base (0ee4234) to head (690d570).
⚠️ Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2702      +/-   ##
============================================
+ Coverage     74.29%   74.31%   +0.01%     
============================================
  Files           129      129              
  Lines         70974    70974              
============================================
+ Hits          52731    52744      +13     
+ Misses        18243    18230      -13     

see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch 8 times, most recently from 769325d to 050f73c Compare November 5, 2025 18:37
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review November 5, 2025 20:01
@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Nov 5, 2025

@hpatro @roshkhatri I added a link in the PR description to visualize the test.
Currently, it only ran for 8.0 and 8.1 in my fork, because I only had those branches in my fork. In valkey repo, it should be running on all the Valkey released branches. Please take a look.

Do they conflict with each other or they just run in queued manner.

They run in a queued manner.

@hpatro hpatro requested a review from roshkhatri November 6, 2025 23:11
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roshkhatri
Copy link
Member

Can you also add screen shots of the workflow runs as an example in the top comment??

@hpatro hpatro requested a review from madolson November 11, 2025 19:10
@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Nov 11, 2025

@roshkhatri there is a link in the top comment to display how it looks like.
PS: It only ran on 8.0 and 8.1 branches because locally I had fetched only those two branches.

Copy link
Member

@Nikhil-Manglore Nikhil-Manglore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakaggarwal97
Copy link
Contributor Author

@madolson please help review whenever you get a chance! Thank you!

@sarthakaggarwal97
Copy link
Contributor Author

@madolson are we good to merge this?

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the weekly-release-daily-tests branch from 45a2e7c to 403b6e1 Compare January 6, 2026 04:35
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@madolson madolson merged commit 35fdcea into valkey-io:unstable Jan 6, 2026
36 of 37 checks passed
jdheyburn pushed a commit to jdheyburn/valkey that referenced this pull request Jan 8, 2026
Resolves: valkey-io#2228

Visualization:
https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295

Currently, there are no tests running on the already released branches.
We often do backport for bug fixes and CVEs in these older versions, and
end up with multiple CI tests failures on these branches.

The PR adds support for running weekly tests on already released
versions `>= 7.2`. The workflow will execute the "daily" test workflow
for each of these branches on `Sunday 06:00 UTC`.

The idea is to continuously monitor our released versions through weekly
test runs (during the time when is lesser activity on github runners).

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@madolson
Copy link
Member

@sarthakaggarwal97 This doesn't seem to have run for some reason, https://github.com/valkey-io/valkey/actions/workflows/daily.yml, can you take a look?

@sarthakaggarwal97
Copy link
Contributor Author

yeah, it was run but looks like some permission issue. Both of my PRs probably had conflict of permissions.
I can see the issue here - https://github.com/valkey-io/valkey/actions/runs/20890545320

@sarthakaggarwal97
Copy link
Contributor Author

I am taking a look.

@sarthakaggarwal97
Copy link
Contributor Author

Raised a PR fix: #3045

harrylin98 pushed a commit to harrylin98/valkey_forked that referenced this pull request Feb 19, 2026
Resolves: valkey-io#2228

Visualization:
https://github.com/sarthakaggarwal97/valkey/actions/runs/19113712295

Currently, there are no tests running on the already released branches.
We often do backport for bug fixes and CVEs in these older versions, and
end up with multiple CI tests failures on these branches.

The PR adds support for running weekly tests on already released
versions `>= 7.2`. The workflow will execute the "daily" test workflow
for each of these branches on `Sunday 06:00 UTC`.

The idea is to continuously monitor our released versions through weekly
test runs (during the time when is lesser activity on github runners).

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Run the whole test suite weekly on release branches

5 participants