Skip to content

Fix flaky PUBSUB pattern tests by making channel names deterministic #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix flaky PUBSUB pattern tests by making channel names deterministic #4994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9547901
Fix flaky PUBSUB pattern tests by making channel names deterministic
jh1231223 Nov 21, 2025
5ae5864
Format PUBSUB pattern tests to satisfy black
jh1231223 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions python/tests/async_tests/test_pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ async def test_pubsub_exact_happy_path_many_channels(

# Create a map of channels to random messages with shard prefix
channels_and_messages = {
f"{shard_prefix}{get_random_string(10)}": get_random_string(5)
for _ in range(NUM_CHANNELS)
f"{shard_prefix}{get_random_string(10)}:{i}": get_random_string(5)
for i in range(NUM_CHANNELS)
}

callback, context = None, None
Expand Down Expand Up @@ -602,8 +602,8 @@ async def test_sharded_pubsub_many_channels(

# Create a map of channels to random messages with shard prefix
channels_and_messages = {
f"{shard_prefix}{get_random_string(10)}": get_random_string(5)
for _ in range(NUM_CHANNELS)
f"{shard_prefix}{get_random_string(10)}:{i}": get_random_string(5)
for i in range(NUM_CHANNELS)
}

callback, context = None, None
Expand Down Expand Up @@ -683,12 +683,12 @@ async def test_pubsub_pattern(
try:
PATTERN = "{{{}}}:{}".format("channel", "*")
channels = {
"{{{}}}:{}".format("channel", get_random_string(5)): get_random_string(
5
),
"{{{}}}:{}".format("channel", get_random_string(5)): get_random_string(
5
),
"{{{}}}:{}:0".format(
"channel", get_random_string(5)
): get_random_string(5),
"{{{}}}:{}:1".format(
"channel", get_random_string(5)
): get_random_string(5),
}

callback, context = None, None
Expand Down Expand Up @@ -817,10 +817,10 @@ async def test_pubsub_pattern_many_channels(
NUM_CHANNELS = 256
PATTERN = "{{{}}}:{}".format("channel", "*")
channels = {
"{{{}}}:{}".format("channel", get_random_string(5)): get_random_string(
5
)
for _ in range(NUM_CHANNELS)
"{{{}}}:{}:{}".format(
"channel", get_random_string(5), i
): get_random_string(5)
for i in range(NUM_CHANNELS)
}

callback, context = None, None
Expand Down
Loading