Fix flaky PUBSUB pattern tests by making channel names deterministic #4994
+14
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4944
This PR stabilizes the following tests:
test_pubsub_exact_happy_path_many_channelstest_sharded_pubsub_many_channelstest_pubsub_patterntest_pubsub_pattern_many_channelsThis work follows the same approach used in:
What I changed
I updated the channel-name construction in the affected tests to make each channel deterministically unique while preserving the original semantics (same shard / same pattern).
Specifically, by embedding the loop index into each channel name:
Validation
Tested locally with repeated runs:
python -m pytest -c /dev/null -q \ tests/async_tests/test_pubsub.py \ -k "[test_name]" \ --count=600 -s --maxfail=1