Skip to content

Further Training Improvements #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Nov 1, 2024

Internal Notes for Reviewers

New intent

  • Establish a slightly different naming convention for course paths (role > course name)
  • Fix the 404 Beck identified
  • Experiment:
    • Further .preview improvements:
      • Support external URLs — ec9f2c5 (different branch)
      • Support optional width & height parameters — 6ccd6ac (different branch)

Original intent — was mostly included in Beck's original PR

This PR modifies @validbeck's #501 to create a more home page-like feel for our training content:

  • Change title to pagetitle
  • Add a hero banner for training
  • Switch column widths to hide left navtree and space out sections
  • Add some bespoke CSS to support the new look
image

External Release Notes

@nrichers nrichers added DO NOT MERGE PR is not ready to be merged internal Not to be externalized in the release notes labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

A PR preview is available: Preview URL

@nrichers nrichers changed the title Nrichers/sc 7134/docs audit p6 training Training Landing Page Experiments Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

A PR preview is available: Preview URL

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 2, 2024

A PR preview is available: Preview URL

Copy link
Contributor

github-actions bot commented Nov 2, 2024

A PR preview is available: Preview URL

Copy link
Contributor

github-actions bot commented Nov 4, 2024

A PR preview is available: Preview URL

color: #042426;
}

.preview {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to investigate but I did something to break my .preview extension ... It affects all course registration pages. Example:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be an issue in this PR as Beck's initial PR that my branch is based on does not exhibit this behaviour. But here's a data point: it looks like we're still showing the .qmd file in the output when we should be referencing the .html:

image

@nrichers nrichers added the enhancement New feature or request label Nov 4, 2024
@validbeck
Copy link
Collaborator

validbeck commented Nov 5, 2024

@nrichers When you shuffle the folder names around, can you make sure the example is updated in the training section of the style guide as well? My silly butt missed it on the 1st round...

Screenshot 2024-11-04 at 5 39 32 PM

EDIT: I forgot to update the fundamentals.qmd template in our internal folder as well to match the new styling... 🤦🏻

@nrichers
Copy link
Collaborator Author

nrichers commented Nov 5, 2024

@nrichers When you shuffle the folder names around, can you make sure the example is updated in the training section of the style guide as well?

Yup! Not a problem at all.

@nrichers nrichers changed the title Training Landing Page Experiments Further Training Improvements Nov 5, 2024
@nrichers
Copy link
Collaborator Author

nrichers commented Nov 5, 2024

This PR has been replaced by #509, closing.

@nrichers nrichers closed this Nov 5, 2024
@nrichers nrichers deleted the nrichers/sc-7134/docs-audit-p6-training branch November 5, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged enhancement New feature or request internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants