-
Notifications
You must be signed in to change notification settings - Fork 4
Training style overhaul + style/accuracy edit #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
PR SummaryThis pull request introduces several enhancements and fixes across multiple files related to course templates and documentation within the ValidMind project. Key changes include:
These changes aim to enhance the overall user experience, improve documentation clarity, and ensure the platform's visual consistency. Test Suggestions
|
A PR preview is available: Preview URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR. 💖 You made a TON of improvements to our training content that move the needle on the look and feel, introducing that separate-yet-related look we talked about. I also appreciate the many smaller changes you made, like the use of {.bubble}
.
My only suggestion would be around the sidebar on the main training page which we talked about a bit already. I agree with your assessment about the look and feel being off if you just use the regular background but my question is: do we NEED a sidebar on that page at all?
I pushed d19bd85 to show what a sidebar-less training landing page might look like. The only useful thing you lose is the search box but with the reimplementation of search on the front page, we could move search into the navbar.
d19bd85
to
f732011
Compare
A PR preview is available: Preview URL |
It still didn't look quite right without the sidebar (so much empty space, and using the page fill options made it worse...), so what I did instead was get rid of the navbar to reduce visual clutter: EDIT: Caveat that on the preview the sidebar title icon won't take you to the proper |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
Can we wait with merging this PR until we've had a chance to make some additional changes, please? I think I had revelation while thinking about this and looking at some other training portals for inspiration. Eventually, that training landing page will morph into something that stands alone as the home page on a separate training portal. That new training portal will feel more like the current home page of our docs site, with:
In preparation for that future, my preference would be to get rid of the sidebar long before getting rid of the navbar. I'd like there to be some natural progression as we iterate over the training content. So here's the revelation, though you kinda have to squint and imagine the future ... For now, maybe the answer lies in introducing another item of visual interest, like a hero banner that stretches across to solve the issue you are concerned about. That would solve the empty space problem as the banner can stretch across, and then we list the current content as is. Take a look at Airtable's academy for an extremely simple example. And I'll even let you make our hero banner somewhat pink — if the docs home site uses pink as the main accent colour with a dark green hero banner, then the training site could invert this colour scheme. EDIT: Another example to look at is https://graphacademy.neo4j.com/ — extremely simple but visually more interesting hero banner that goes across, with a simple but appealing text CTA. |
Related to my previous comment, I'd like to discuss the new training content layout with Mehdi this coming week. It would be helpful to have that precursor to a new training portal home page in place, even if it requires some squinting and imagination for now. |
It's why I left this as is without merging, yes. I personally really like the sidebar as opposed to the navbar (and I actually based the entire redesign around it, so to me it doesn't feel cohesive without it), but we'll just have to agree to disagree there and you do happen to have an override if you're really adamant about it. :)
It's not really about "stretching across" for me (as I played around with scretching the page content before I readded the sidebar)... it's just that I think the swap between the nav & sidebar really visually distinct and I like that much more. |
I don't think it works for a training home page and there's a reason we don't use this approach on our home page. But let's let this sit for a few hours and discuss later. I need to focus on some product footage for Kevin for now and won't have time to tinker with alternatives until the afternoon most likely. |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
A PR preview is available: Preview URL |
Another item for us to discuss: I like the idea of breaking things down into different paths, but the folder path should reflect the course name. Soon enough, we will have multiple courses for developers, for example, so rather than having to rename existing courses, it would be good to agree on a convention now that does not require future file reshuffling. This will become especially important as we will likely have quite a few links from our CSM org and other places to training content. |
Internal Notes for Reviewers
LIVE PREVIEW
New training stylesheet
Now the training pages have their own adjusted look and feel — the dark green and light teal are the focus instead of the pink:
New Revealjs slides styling
.overlay
class with our own custom styling that matches our theme instead of pulling from the Tachyons library (by calling one class rather than multiple additional Tachyons CSS ones!):documentation/site/training/assets/custom.scss
Line 39 in edbbc2e
.embed
class that takes care of the slide navigation single-source file styling and the callouts within the overlays:documentation/site/training/assets/custom.scss
Line 52 in edbbc2e
Reorganized contents of training folder
fundamentals.qmd
template in our internal templates folder: internal/templates/fundamentals.qmdSlide updates
Administrator fundamentals
I single-sourced the basic workflow setup instructions and inserted them into the
Configure workflows
section, and removed any references to the outdated model documentation workflow that used to exist:Role & status styling
.bubble
class to reflect the way roles and statuses are displayed within the UI:documentation/site/styles.css
Line 470 in edbbc2e