Skip to content

Create CI check for Release Notes #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jun 24, 2023
Merged

Create CI check for Release Notes #105

merged 40 commits into from
Jun 24, 2023

Conversation

sydneysugar
Copy link
Contributor

@sydneysugar sydneysugar commented Jun 21, 2023 •
edited
Loading

Internal Notes for Reviewers

Create first draft of CI check for release notes process.

External Release Notes

Sample description to test generate release notes script.

@sydneysugar sydneysugar added the infrastructure Docs infra changes label Jun 21, 2023
@sydneysugar sydneysugar requested a review from nrichers June 21, 2023 21:08
@sydneysugar sydneysugar added internal Not to be externalized in the release notes and removed internal Not to be externalized in the release notes infrastructure Docs infra changes labels Jun 22, 2023
nrichers
nrichers reviewed Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this CI check, @sydneysugar! I left some comments that will need to be addressed after you merge #106.

sydneysugar and others added 5 commits June 22, 2023 14:59
@sydneysugar
Update for new PR template
30b9e02
@sydneysugar @nrichers
Rename workflow
a52a2d8 
Co-authored-by: Nik Richers <nik@validmind.ai>
@sydneysugar @nrichers
Update 'label' error message
16713b6 
Co-authored-by: Nik Richers <nik@validmind.ai>
@sydneysugar @nrichers
Update 'release notes' error message
e925ec6 
Co-authored-by: Nik Richers <nik@validmind.ai>
@sydneysugar
Address PR template change
1ef5e20
@sydneysugar sydneysugar added internal Not to be externalized in the release notes bug Something isn't working and removed internal Not to be externalized in the release notes labels Jun 22, 2023
@sydneysugar sydneysugar added the infrastructure Docs infra changes label Jun 22, 2023
@sydneysugar sydneysugar removed the bug Something isn't working label Jun 23, 2023
@github-actions
Copy link
Contributor

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@sydneysugar
Copy link
Contributor Author

I updated the script so that the error messages for "no description" and for "no label and no description" are shown even when the root comment is empty.

@nrichers nrichers added the bug Something isn't working label Jun 24, 2023
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@nrichers nrichers added infrastructure Docs infra changes internal Not to be externalized in the release notes bug Something isn't working and removed bug Something isn't working infrastructure Docs infra changes internal Not to be externalized in the release notes labels Jun 24, 2023
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

4 similar comments
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@nrichers nrichers added infrastructure Docs infra changes internal Not to be externalized in the release notes and removed bug Something isn't working labels Jun 24, 2023
nrichers
nrichers approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks GREAT to me)! Awesome work, @sydneysugar! I retested your PR and it seems to work as expected. Kudos on your first big contribution to our docs infra. 🚀

@nrichers nrichers merged commit a470682 into main Jun 24, 2023
@nrichers nrichers deleted the release-notes-ci-check branch June 24, 2023 00:33
@sydneysugar sydneysugar added bug Something isn't working and removed infrastructure Docs infra changes internal Not to be externalized in the release notes labels Jun 28, 2023
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

2 similar comments
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@sydneysugar sydneysugar added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrichers nrichers nrichers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydneysugar @nrichers