Skip to content

Hide external release notes instructions #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2023
Merged

Hide external release notes instructions #106

merged 2 commits into from
Jun 22, 2023

Conversation

sydneysugar
Copy link
Contributor

@sydneysugar sydneysugar commented Jun 22, 2023 •
edited
Loading

Internal Notes for Reviewers

Changed text to a comment so that this text can be ignored during the CI check

External Release Notes

Test description 12 for deprecation label.

@sydneysugar
Hide external release notes instructions
779bb25 
Changed text under '## External Release Notes' to a comment so that this text can be ignored during the CI check
@sydneysugar sydneysugar requested a review from nrichers June 22, 2023 18:05
nrichers
nrichers reviewed Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with some instructions for using labels and to separate the instructions from the release notes section. Let me know what you think?

@sydneysugar
Copy link
Contributor Author

Looks good! I'll update the script with the new format.

nrichers
nrichers approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@nrichers nrichers mentioned this pull request Jun 22, 2023
Merged
@sydneysugar sydneysugar merged commit 7aa9b74 into main Jun 22, 2023
@sydneysugar sydneysugar deleted the hide-pr-description branch June 22, 2023 22:07
@sydneysugar sydneysugar added bug Something isn't working enhancement New feature or request highlight Feature to be curated in the release notes labels Jul 5, 2023
@sydneysugar sydneysugar added deprecation Feature to be removed for the release notes and removed bug Something isn't working enhancement New feature or request highlight Feature to be curated in the release notes labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrichers nrichers nrichers approved these changes

Assignees
No one assigned
Labels
deprecation Feature to be removed for the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydneysugar @nrichers