fix(isPassportNumber): improve CA
locale
#2526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update isPassportNumber to cover both new and old Canadian passport number formats
Regex now covers both of the following patterns:
Modify existing CA isPassportNumber regular expression to cover new format and old format.
Update test cases to cover new format, and add additional invalid passport number cases
Old format:
/^[A-Z]{2}\d{6}$
New format:
^[A-Z]\d{6}[A-Z]{2}$/
Combined into a single regular expression:
/^[A-Z]{2}\d{6}$|^[A-Z]\d{6}[A-Z]{2}$/
Sources
closes: #2525
Checklist