Skip to content

maintenance: 2505 release #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

maintenance: 2505 release #2560

merged 2 commits into from
May 28, 2025

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented May 14, 2025

13.15.15

Fixes, New Locales and Enhancements

@WikiRik WikiRik requested review from profnandaa and rubiin May 14, 2025 15:50
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9e50384) to head (4d58193).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2535           
  Branches       641       641           
=========================================
  Hits          2535      2535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik
Copy link
Member Author

WikiRik commented May 14, 2025

@profnandaa I ran prettier locally and it changed some additional lines. Let me know if you want me to revert those changes.

rubiin
rubiin previously approved these changes May 14, 2025
@bc-m
Copy link
Contributor

bc-m commented May 15, 2025

Should the isUUID default be ‘loose’ to undo the breaking change from #2421 before the new release lands?

@WikiRik
Copy link
Member Author

WikiRik commented May 15, 2025

Should the isUUID default be ‘loose’ by default to undo the breaking change from #2421 before the new release lands?

Personally, I don't agree with that. I see where you are coming from, and that the previous release could be considered a breaking change. Currently I do not see the need to change the default behaviour, and with this release we give people that had issues with the current release another way to deal with UUIDs.

profnandaa
profnandaa previously approved these changes May 19, 2025
CHANGELOG.md Outdated
@@ -1,3 +1,32 @@
# 13.15.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: will bump up the patch number further to be approx. the number of patches; that has been the previous convention...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the patch version accordingly. Will keep it in mind for next time

@WikiRik WikiRik dismissed stale reviews from profnandaa and rubiin via 4d58193 May 26, 2025 16:33
@WikiRik WikiRik requested review from rubiin and profnandaa May 26, 2025 16:34
@profnandaa
Copy link
Member

profnandaa commented May 26, 2025 via email

@profnandaa profnandaa merged commit 3847c6f into master May 28, 2025
13 checks passed
@profnandaa profnandaa deleted the release/2505 branch May 28, 2025 04:29
@profnandaa
Copy link
Member

@profnandaa
Copy link
Member

https://github.com/validatorjs/validator.js/releases/tag/13.15.15
Once again, thanks @WikiRik for preparing this! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants