const phones ordered

[alamparelli]

Ordered phones object in isMobilePhone.js to improve readability for future contributors

Good morning, I have ordered the key in the phones object to improve the readability for future contributions

• linked to this Mobile Phone validations - For The First Time Contributors #1761

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable) : N/A
• Tests written (where applicable) : N/A
  • NPM test ran successfully
• References provided in PR (where applicable) : N/A

[WikiRik]

Thanks for this PR. Did you do this manually or with some kind of eslint rule (or something similar)? If there is an automatic way that we can check this, and other objects, that would be nice

[alamparelli]

Thanks for this PR. Did you do this manually or with some kind of eslint rule (or something similar)? If there is an automatic way that we can check this, and other objects, that would be nice

Hello @WikiRik,
I did manually to not alter the way the code is builded.

May be some functions could be developed to sort automatically all the objects with a mechanism that could run prior to the npm test.

[alamparelli]

@WikiRik,
I have searched yesterday and there is indeed an eslint plugin that could match the requirement but dependencies are not met in the project. I have not yet the experience to fix dependencies. I could have a look in a separate PR.

• eslint-plugin-perfectionist come with a sort-object option and autofix.
  • npm audit : found 0 vulnerabilities

package.json

{
  "devDependencies": {
    "eslint": "^9.6.0",
    "eslint-plugin-perfectionist": "^2.11.0"
  }
}

eslint.config.mjs

import js from '@eslint/js';
import perfectionist from 'eslint-plugin-perfectionist'

export default [
	{
	  	plugins: {
		perfectionist,
	}, 
	rules: {
	'perfectionist/sort-objects': [
        'error',
        {
          'custom-groups': {
            id: 'id',
          },
          groups: ['id', 'unknown'],
          order: 'asc',
          'partition-by-comment': 'Part:**',
          type: 'natural',
        },
      ],		 
	},
	},
	js.configs.recommended,
	{
		rules: {
		},
	},
];