Mobile Phone validations - For The First Time Contributors #1761

ezkemboi · 2021-10-08T04:33:50Z

I would like to give this to the people who are new and would like to start contributing to validator.js.

The current version in isMobilePhone validation, we have less than 195 phone validations i.e

In the code https://github.com/validatorjs/validator.js/blob/master/src/lib/isMobilePhone.js, the validations exist from line 5 to line 119, which means we have probably 119 - 5 countries phone validations. Where might be other countries? That is up to someone who would like to choose which country does not exist and create a new validation for the same.

When making this change, apart from the file above, also add tests and update the isMobilePhone section in the README.

Also, please check on existing PR's if the country you choose to validate mobile phone numbers does not have an already PR raised.

All Prs are welcomed and we will do a review on the same

The text was updated successfully, but these errors were encountered:

ezkemboi · 2021-10-08T06:23:39Z

Great catch, please do add @mairagee524 and reference your PR to this issue with the correct title such as
phone number for Mexico(code) etc.

Thanks and looking forward to your PR.
I will also double-check on the same.

pasagedev · 2021-10-08T17:14:14Z

It seems that Cuba is not on the list either, could I work on that ?

ezkemboi · 2021-10-08T17:17:49Z

Sure, please do.

…

On Fri, Oct 8, 2021, 8:14 PM Pablo Salas Gelich ***@***.***> wrote: It seems that Cuba is not on the list either, could I work on that ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALVWPH756XKT3WGXB4RZAELUF4RHDANCNFSM5FSXM3NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

neel-desh · 2021-10-09T12:15:17Z

Afghanistan is also missing, working on that...

ezkemboi · 2021-10-09T12:43:26Z

Please do add and raise a Pr

…

On Sat, Oct 9, 2021, 3:15 PM Neel Deshmukh ***@***.***> wrote: Afghanistan is also missing, I belive — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALVWPH3HH5S7MKWFE26FRYLUGAW57ANCNFSM5FSXM3NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

neel-desh · 2021-10-09T12:49:17Z

Please do add and raise a Pr
…
On Sat, Oct 9, 2021, 3:15 PM Neel Deshmukh @.***> wrote: Afghanistan is also missing, I belive — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVWPH3HH5S7MKWFE26FRYLUGAW57ANCNFSM5FSXM3NQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yes, I did.

Btw, for new contributors, what i did was find list of the country code and their ISO codes, wrote simple program to filter non existing countries and wrote the code.

here are the resources :
https://www.att.com/support_media/images/pdf/Country_Code_List.pdf
https://countrycode.org/

@ezkemboi I'm not adding all the missing country code validations, i would like other people to contribute, but after October if still there are no contributions in this or we have missing validations, I would try to complete the list...

ezkemboi · 2021-10-09T12:53:17Z

Sure thing.

…

On Sat, Oct 9, 2021, 3:49 PM Neel Deshmukh ***@***.***> wrote: Please do add and raise a Pr … <#m_7010722731381047102_> On Sat, Oct 9, 2021, 3:15 PM Neel Deshmukh *@*.***> wrote: Afghanistan is also missing, I belive — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1761 (comment) <#1761 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVWPH3HH5S7MKWFE26FRYLUGAW57ANCNFSM5FSXM3NQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . Yes, I did. Btw, for new contributors, what i did was find list of the country code and their ISO codes, wrote simple program to filter non existing countries and wrote the code. here are the resources : https://www.att.com/support_media/images/pdf/Country_Code_List.pdf https://countrycode.org/ @ezkemboi <https://github.com/ezkemboi> I'm not adding all the missing codes as, i would like other people to contribute, but after October if still there are no contributions, I would try to complete the list... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALVWPH46IX2ZGVOLK4A7SZTUGA25RANCNFSM5FSXM3NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

mgndolan · 2021-10-10T03:05:10Z

I didn't see Botswana on the list. Could I add this validation?

ezkemboi · 2021-10-10T06:10:59Z

@mgndolan please add that and raise a PR, I will review that.

rootkit7628 · 2021-10-10T07:24:26Z

It seems like Madagascar in not on the list. Could I add this validation?

Sidd2024 · 2021-10-10T08:20:39Z

looks like grenada is also not there in the list, should i add this a validation for this?

ezkemboi · 2021-10-10T08:59:56Z

Please do add them.

…

On Sun, Oct 10, 2021, 11:20 AM Siddhant Sharma ***@***.***> wrote: looks like grenada is also not there in the list, should i add this a validation for this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALVWPH3S2B3UKSG6BKHYNQ3UGFEGFANCNFSM5FSXM3NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

lakshayr003 · 2021-10-10T15:19:30Z

It seems like Bhutan is not on the list, should I add validation for this? @ezkemboi

ezkemboi · 2021-10-10T15:41:28Z

Yes @lakshayr003

HackProAIT · 2021-10-10T18:23:56Z

It would we nice if we could write comment country name in front of each country code.

tarob0ba · 2021-10-10T22:54:16Z

I was just poking around and noticed that there wasn't an entry for Cameroon. Should I work on this?

tarob0ba · 2021-10-11T02:20:20Z

Opened PR #1772.

ezkemboi · 2021-10-11T02:34:25Z

Good stuff @beckettnormington.
Thanks all for opening PRs, let's keep them coming.
I will spend this week reviewing them.

Madhavi96 · 2021-10-11T03:20:57Z

@ezkemboi Hi!
I previously did a contribution to this project, by adding mobile phone number validation for Sri Lanka. I was inspired to participate in Hacktoberfest this time and reached out again.

Just noticed that the contribution I added to validate mobile numbers in Sri Lanka has been replaced by this:
en-SL': /^(\+?232|0)\d{8}$/

However, it does not validate mobile numbers in Sri Lanka correctly (sources: https://en.wikipedia.org/wiki/Telephone_numbers_in_Sri_Lanka).

Is there a specific reason for the change?
If not, I can make the necessary changes to make it work correctly again. Thank you!

ezkemboi · 2021-10-11T03:22:30Z

Please do make the changes @Madhavi96 .
But, also, I will need to make sure why it was changed and if the changes made are also necessary.
Thank you.

Madhavi96 · 2021-10-11T03:33:51Z

Thanks. Let me know if you find anything on the requirement for the change. Until then I'll do the changes and raise a PR.

Madhavi96 · 2021-10-11T16:30:19Z

@ezkemboi Found the validation for Sri Lanka, under 'si-LK': /^(?:0|94|\+94)?(7(0|1|2|5|6|7|8)( |-)?\d)\d{6}$/, and that is correct

Apologies for the false alarm!

ezkemboi · 2021-10-11T17:43:16Z

No worries

…

On Mon, Oct 11, 2021, 7:30 PM Ishara Madhavi ***@***.***> wrote: @ezkemboi <https://github.com/ezkemboi> Found the validation for Sri Lanka, under 'si-LK': /^(?:0|94|\+94)?(7(0|1|2|5|6|7|8)( |-)?\d)\d{6}$/, and that is correct Apologies for the false alarm! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALVWPH5QRBHWNFGD4W3X6YLUGMGKLANCNFSM5FSXM3NQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Siddhant-Kashyap · 2023-08-04T16:49:34Z

Hi!
Founded that ' Guam ' phone number is not added in the list so i am adding it
#2255
Please someone review it .

SimranSiddiqui · 2023-08-16T00:28:34Z

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

WikiRik · 2023-08-16T06:04:23Z

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

@SimranSiddiqui of course, go ahead! Do also check out what was done in the past; #1823

SimranSiddiqui · 2023-08-17T12:36:17Z

Hey! I would like to do my first contribution. I saw Malawi is not on the list. Can I work on that?

@SimranSiddiqui of course, go ahead! Do also check out what was done in the past; #1823

#2267

ShambhavII-Singh · 2023-09-22T12:28:55Z

Hey! I did not find Croatia on the list. Can I add that? I will be making a PR shortly.

Manu024 · 2023-09-27T08:45:01Z

Hi Devs, I couldnt find Puerto Rico in the list. I would like to contribute by creating a PR?

Excited to start my first open source contribution if it helps.

I found myself to make the changes in readme, isMobilePhone.js, validators.test.js files. Did I missed anything?

WikiRik · 2023-09-27T08:51:02Z

Feel free to contribute to this. No need to ask permission, but do check if there is already an open PR with the locale.

Most useful sources are the ITU and libPhoneNumber from Google but additional (local) sources are also welcomed

Changes are indeed made in the README, isMobilePhone.js and validators.test.js

Manu024 · 2023-09-28T13:18:59Z

Created #2292 PR for Puerto Rico . Please review.

Thanks in Advance

Swamynathan-R · 2023-10-14T14:57:44Z

created #2321 PR for Monaco, Please check and review.

Thank you.

sadraliev · 2024-01-08T18:45:48Z

Hello, can I create a PR to update the regular expression for Kyrgyzstan phone numbers? The ones currently in place are not up to date.

profnandaa · 2024-01-09T02:40:49Z

Pls do. Sorry we haven't done the pending release yet but I'm working on that. ./na

…

On Mon, Jan 8, 2024, 21:46 sadraliev ***@***.***> wrote: Hello, can I create a PR to update the regular expression for Kyrgyzstan phone numbers? The ones currently in place are not up to date. — Reply to this email directly, view it on GitHub <#1761 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB7ZEMNJGPHUWWBX5Z2CMLYNQ5GRBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIYTANRWHE4DINRVGCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRRGMYTSNRSGE3TAN5ENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWTDSNRVG44DFAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCMBSGA3DQNZWGEZIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIYTANRWHE4DINRVGCBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGEZTCOJWGIYTOMBXU52HE2LHM5SXFJTDOJSWC5DF> . You are receiving this email because you modified the open/close state. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

sadraliev · 2024-01-09T20:09:10Z

Created #2350 PR for Kyrgyz Republic . Please review.

Thanks in Advance! 🖖

Added mobile phone code for Canada

ignaciosuarezquilis · 2024-05-06T01:47:04Z

Hi, it seems that vatican city is not listed, can I work on that?

jmustafa-96 · 2024-05-07T07:04:29Z

Hey! I would like to do my first contribution. I saw CONGO is not on the list. Can I work on that?

SurajSivakumar07 · 2024-05-07T08:41:22Z

Shall I add Vatican City validation ?

WikiRik · 2024-05-07T20:41:25Z

There's no way to pin a comment in GitHub, so I'll copy my earlier comment to here;

Feel free to contribute to this. No need to ask permission, but do check if there is already an open PR with the locale.

Most useful sources are the ITU and libPhoneNumber from Google but additional (local) sources are also welcomed

Changes are indeed made in the README, isMobilePhone.js and validators.test.js

legend-crypt · 2024-10-11T13:39:32Z

I would like to add a PR to the list of contacts in Ghana

Yashwanth-Chandrakumar · 2024-10-17T14:35:27Z

/assign

ezkemboi added good first issue enhancement hacktoberfest hacktoberfest-accepted labels Oct 8, 2021

tux-tn removed the hacktoberfest-accepted label Oct 8, 2021

pasagedev mentioned this issue Oct 9, 2021

feat: (isMobilePhone) add Cuba validation #1765

Merged

3 tasks

hereje mentioned this issue Oct 9, 2021

feat: (isMobilePhone) add El Salvador validation #1766

Closed

3 tasks

0APOCALYPSE0 mentioned this issue Oct 1, 2023

add Saint Martin (French) mobile number validation #2297

Open

amansaurabh mentioned this issue Oct 2, 2023

Added mobile phone validations for the 10 countries. #2302

Open

4 tasks

This was referenced Oct 2, 2023

regex added for Senegal sn-SN #2303

Closed

regex added for Senegal sn-SN #2304

Open

This was referenced Jan 28, 2024

FEAT: Added the mobile number validator for MARSHALL ISLANDS #2365

Open

FEAT: Updated the readme and added tests for validator of Marshall Islands country #2367

Open

ATodd1 pushed a commit to ATodd1/validator.js that referenced this issue Mar 15, 2024

updated MobilePhone.js issue validatorjs#1761

61624ba

Added mobile phone code for Canada

SurajSivakumar07 added a commit to SurajSivakumar07/validator.js that referenced this issue May 7, 2024

validatorjs#1761 added Vatican City mobile validation

ffefb55

DOOMSDAY101 mentioned this issue May 9, 2024

added phone number regex #2396

Open

4 tasks

alamparelli mentioned this issue Jun 29, 2024

const phones ordered #2428

Closed

5 tasks

anonYmousFPP mentioned this issue Sep 25, 2024

Feat: Mobile Phone validations Add Mexico #2457

Open

Mobile Phone validations - For The First Time Contributors #1761

Mobile Phone validations - For The First Time Contributors #1761

Comments

ezkemboi commented Oct 8, 2021

ezkemboi commented Oct 8, 2021

pasagedev commented Oct 8, 2021

ezkemboi commented Oct 8, 2021 via email

neel-desh commented Oct 9, 2021 • edited Loading

ezkemboi commented Oct 9, 2021 via email

neel-desh commented Oct 9, 2021 • edited Loading

ezkemboi commented Oct 9, 2021 via email

mgndolan commented Oct 10, 2021

ezkemboi commented Oct 10, 2021

rootkit7628 commented Oct 10, 2021

Sidd2024 commented Oct 10, 2021

ezkemboi commented Oct 10, 2021 via email

lakshayr003 commented Oct 10, 2021

ezkemboi commented Oct 10, 2021

HackProAIT commented Oct 10, 2021

tarob0ba commented Oct 10, 2021

tarob0ba commented Oct 11, 2021

ezkemboi commented Oct 11, 2021

Madhavi96 commented Oct 11, 2021

ezkemboi commented Oct 11, 2021

Madhavi96 commented Oct 11, 2021

Madhavi96 commented Oct 11, 2021

ezkemboi commented Oct 11, 2021 via email

Siddhant-Kashyap commented Aug 4, 2023 • edited Loading

SimranSiddiqui commented Aug 16, 2023

WikiRik commented Aug 16, 2023

SimranSiddiqui commented Aug 17, 2023

ShambhavII-Singh commented Sep 22, 2023

Manu024 commented Sep 27, 2023

WikiRik commented Sep 27, 2023

Manu024 commented Sep 28, 2023 • edited Loading

Swamynathan-R commented Oct 14, 2023

sadraliev commented Jan 8, 2024

profnandaa commented Jan 9, 2024 via email

sadraliev commented Jan 9, 2024

ignaciosuarezquilis commented May 6, 2024

jmustafa-96 commented May 7, 2024

SurajSivakumar07 commented May 7, 2024

WikiRik commented May 7, 2024

legend-crypt commented Oct 11, 2024

Yashwanth-Chandrakumar commented Oct 17, 2024

neel-desh commented Oct 9, 2021 •

edited

Loading

neel-desh commented Oct 9, 2021 •

edited

Loading

Siddhant-Kashyap commented Aug 4, 2023 •

edited

Loading

Manu024 commented Sep 28, 2023 •

edited

Loading